Open Bug 1592633 Opened 1 year ago Updated 4 months ago

Handling differences in prefs between browsertime and raptor-browsertime

Categories

(Testing :: Raptor, task, P3)

Version 3
task

Tracking

(Not tracked)

People

(Reporter: sparky, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

This bug is to discuss what we should do in terms of handling pref settings across browsertime, and raptor-browsertime. There are three pref setting options: (i) browsertime, (ii) perf-profile (raptor-browsertime settings), or (iii) browsertime+perf-profile.

One option, as :acreskey suggested, is the following:

One way to allow the 3 sets of prefs (browsertime, perf profile, browsertime+perf profile) to work consistenly:
We could add a flag to browsertime to ignore the default firefoxPreferences.js
Denis has already done something similar to provide an easy way to disable safebrowsing:
https://github.com/mozilla/browsertime/blob/master/lib/firefox/webdriver/index.js#L137
Similarly, we could skip the default pref injection here with an option flag:
https://github.com/mozilla/browsertime/blob/master/lib/firefox/webdriver/index.js#L76
Priority: -- → P2

This is the impact of adding the marionette prefs to raptor:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=f8a86eaf23dc0b5fec01af18a8c2a487c551a119&newProject=try&newRevision=f6bc22a9f7b73684b79134c8d8fd2ec92f680899&framework=10

The only change marked as significant by perfherder is a 2% improvement on raptor-tp6-bing-firefox-cold on OSX.
In my opinion, I think we can live with that.

First part of this work is will be done in bug 1620271.

Depends on: 1620271

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Severity: normal → S3
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.