1592720 - Enable WatchPoints in all channels

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Enable WatchPoints in all channels as soon as ready.

Honza

Comment 1

[Sebastian Zartner [:sebo]]

Once it ships, it should be mentioned in the release notes.

Sebastian

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1592720 - Enable WatchPoints in all channels

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

QA testing looks good so, we can enable on all channels.

Testing on beta in progress and if good, we can uplift next week

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83253521421
Enable WatchPoints in all channels r=jlast

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81896afbdac40eba499f2a504695dbb2d310b0a9

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d83253521421

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

If you're intending to ship this in 72, could you request uplift? From comments in email and from the Trello card at https://trello.com/c/bAgF83UW/835-debugger-watchpoints looks like 72 is the goal.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9115414 [details]
Bug 1592720 - Enable WatchPoints in all channels

Beta/Release Uplift Approval Request

• User impact if declined: Developers won't have the feature enabled by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature went through QA testing, all look good.
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9115414 [details]
Bug 1592720 - Enable WatchPoints in all channels

turn watchpoints on for 72 beta and release, approved for 72.0b8

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/82d4b686937a

Comment 12

[Chris Mills [:cmills]]

So this was uplifted to 72, and we have covered the new watchpoint UI stuff on MDN and in the 72 rel notes:

• https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_watchpoints
• https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/72#Developer_tools

Therefore I don't think there's anything else for us to do here?

Let me know if I've got this wrong, and i'll be happy to do any further required updates. Thanks!

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Looks great to me, thanks Chris!

Honza