Open Bug 1592764 Opened 4 years ago Updated 1 year ago

Error from missing Intel Power Gadget app trips up mozrunner, overwriting its original error

Categories

(Testing :: Raptor, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: stephend, Unassigned, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [mentored])

User Story

See here for information on how to contribute: https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

Attachments

(1 file)

STR:

  1. Without the Intel Power Gadget installed on Mac (a precondition), apply https://phabricator.services.mozilla.com/D50522
  2. Run ./mach raptor -t raptor-speedometer --power-test

Actual Results:

16:57:28 INFO - raptor-main Info: creating browser runner using mozrunner 16:57:28 INFO - mozpower Intializing measurer MacIntelPower for darwin-intel power measurements, see below for errors... 16:57:28 INFO - raptor-control-server Info: shutting down control server 16:57:28 INFO - raptor-main Info: finished 16:57:28 ERROR - Traceback (most recent call last): 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/raptor/raptor/raptor.py", line 1532, in <module> 16:57:28 INFO - main() 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/raptor/raptor/raptor.py", line 1500, in main 16:57:28 INFO - success = raptor.run_tests(raptor_test_list, raptor_test_names) 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/raptor/raptor/raptor.py", line 213, in run_tests 16:57:28 INFO - self.run_test_teardown(test) 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/raptor/raptor/raptor.py", line 914, in run_test_teardown 16:57:28 INFO - if self.runner.is_running(): 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/mozbase/mozrunner/mozrunner/base/runner.py", line 171, in is_running 16:57:28 INFO - return self.returncode is None 16:57:28 INFO - File "/Users/sdonner/mozilla-source/mozilla-unified/testing/mozbase/mozrunner/mozrunner/base/runner.py", line 87, in returncode 16:57:28 INFO - raise RunnerNotStartedError("returncode accessed before runner started") 16:57:28 INFO - mozrunner.errors.RunnerNotStartedError: returncode accessed before runner started 16:57:28 ERROR - Return code: 1

Expected Results:

Gentler/better error message?

I've attached the full error log from the run; I've also confirmed that installing Intel Power Gadget and re-running the same test in the same terminal window/shell fixes it just fine.

Priority: -- → P2
Priority: P2 → P3
Version: Version 3 → unspecified
Mentor: gmierz2
Keywords: good-first-bug
Whiteboard: [mentored]
User Story: (updated)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.