Closed Bug 1592787 Opened 3 years ago Closed 3 years ago

[motion-1] Check the creation of the stacking context if we don't have offset-path animation and its value is none.

Categories

(Core :: CSS Transitions and Animations, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: boris, Assigned: boris)

References

Details

Attachments

(3 files)

Summary: [motion-1] We should create the stacking context even if we have an animation with offset-path:none → [motion-1] Check the creation of the stacking context if we don't have offset-path animation and its value is none.

Update the title because we would like to land Bug 1429305 first, which fix the stacking context issue, but still has a bug if we have offset-* animations other than offset-path and offset-path is none.

Attachment #9105649 - Attachment filename: file_1592787.txt → test.html
Attachment #9105649 - Attachment mime type: text/plain → text/html
Depends on: 1429305

Note to me:

We should also avoid setting change hint in RestyleManager::AddLayerChangesForAnimation() if we don't have offset-path (and other transform) animations and offset-path is none. Otherwise, we may hit the assertion in ApplyRenderingChangeToTree, if we update nsIFrame::HasAnimationOfTransform() to return false for this case.

So we don't run animations of offset-* if offset-path is none and we
don't have animations of offset-path.

Attachment #9106671 - Attachment description: Bug 1592787 - Fix IsTransforemd() and IsMatchForCompositor. → Bug 1592787 - Fix HasAnimationOfTransform() and IsMatchForCompositor().
Attachment #9106671 - Attachment description: Bug 1592787 - Fix HasAnimationOfTransform() and IsMatchForCompositor(). → Bug 1592787 - Don't run compositor animations if offset-path is not animating and is none.
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bfe8e0917c2
Don't run compositor animations if offset-path is not animating and is none. r=hiro
https://hg.mozilla.org/integration/autoland/rev/102f2c8d8923
No need to send non-animating offset-* if no effective motion path. r=hiro
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
No longer regressions: 1595000
You need to log in before you can comment on or make changes to this bug.