1592787 - [motion-1] Check the creation of the stacking context if we don't have offset-path animation and its value is none.

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect, P2)

Description

[Boris Chiou [:boris]]

We should create a stacking context if we have offset-path animations (even if it is always none).

For example:

span {
  height: 100px;
  width: 100px;
  position: fixed;
  background: green;
  top: 50px;
}
@keyframes offsetNone {
  from { offset-path: none; }
  to { offset-path: none; }
}
#test {
  width: 100px; height: 100px;
  background: blue;
  animation: offsetNone 100s infinite;
}
</style>
<span></span>
<div id="test"></div>

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1592787 - No need to send non-animating offset-* if no effective motion path.

Comment 2

[Boris Chiou [:boris]]

Update the title because we would like to land Bug 1429305 first, which fix the stacking context issue, but still has a bug if we have offset-* animations other than offset-path and offset-path is none.

Comment 3

[Boris Chiou [:boris]]

Attachment: Test case for not creating stacking context if offset-path hasn't any effect

Comment 4

[Boris Chiou [:boris]]

Note to me:

We should also avoid setting change hint in RestyleManager::AddLayerChangesForAnimation() if we don't have offset-path (and other transform) animations and offset-path is none. Otherwise, we may hit the assertion in ApplyRenderingChangeToTree, if we update nsIFrame::HasAnimationOfTransform() to return false for this case.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1592787 - Don't run compositor animations if offset-path is not animating and is none.

So we don't run animations of offset-* if offset-path is none and we
don't have animations of offset-path.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bfe8e0917c2
Don't run compositor animations if offset-path is not animating and is none. r=hiro
https://hg.mozilla.org/integration/autoland/rev/102f2c8d8923
No need to send non-animating offset-* if no effective motion path. r=hiro

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3bfe8e0917c2
https://hg.mozilla.org/mozilla-central/rev/102f2c8d8923