1592871 - The ruleview will be broken if inspects visited link which has style attribute

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: visited-and-style-attribute.html

I got a report for a bug that breaks the ruleview from Brian.

STRs:

1. Open the attachment
2. Inspect a link in the document
   ER: Can inspect correctly
   AR: Will be blank

I have investigated a bit.
Since it seems that the reason is the style which is defined by style attribute does not handle as CSSStyleRule, InspectorUtils.getSelectorCount() throw an exception.
This makes the ruleview to be a blank.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1592871: Avoid passing not CSSStyleRule object into InspectorUtils.getSelectorCount(). r?pbro

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1592871: Add test whether the ruleview will not be broken. r?pbro

Depends on D51219

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6583ceda5259
Avoid passing not CSSStyleRule object into InspectorUtils.getSelectorCount(). r=gl
https://hg.mozilla.org/integration/autoland/rev/e71a201cbda0
Add test whether the ruleview will not be broken. r=gl

Comment 4

[Guilherme Lima]

https://hg.mozilla.org/mozilla-central/rev/6583ceda5259ab31ed77d8605f82f6fcb8c1d779
https://hg.mozilla.org/mozilla-central/rev/e71a201cbda0d753c7a2aa749dc46111b3c79e07

For some reason this bug didn't get marked as fixed.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9105459 [details]
Bug 1592871: Avoid passing not CSSStyleRule object into InspectorUtils.getSelectorCount(). r?pbro

Beta/Release Uplift Approval Request

• User impact if declined: The ruleview of the inspector will be broken if user inspects a link which has :visited state and style attribute.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is one line and affects only the ruleview.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9105459 [details]
Bug 1592871: Avoid passing not CSSStyleRule object into InspectorUtils.getSelectorCount(). r?pbro

P1, minimal patch, impacts devtool users only, uplift approved for 71 beta 7, thanks.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7587e88be5a
https://hg.mozilla.org/releases/mozilla-beta/rev/61390fc77873