1592906 - Crash in [@ mozilla::wr::RenderCompositorOGL::Bind]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-22924265-4b88-4be6-9f00-bfcd00191030.

Top 10 frames of crashing thread:

0 XUL mozilla::wr::RenderCompositorOGL::Bind gfx/webrender_bindings/RenderCompositorOGL.cpp:176
1 XUL <webrender_bindings::bindings::WrCompositor as webrender::composite::Compositor>::bind gfx/webrender_bindings/src/bindings.rs:1206
2 XUL webrender::renderer::Renderer::draw_frame gfx/wr/webrender/src/renderer.rs:5073
3 XUL webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:2973
4 XUL wr_renderer_render gfx/webrender_bindings/src/bindings.rs:623
5 XUL mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:442
6 XUL mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:318
7 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1176
8 XUL MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:523
9 XUL base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35

There are 2 crashes (from 2 installations) in nightly 72 with buildid 20191030215116. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1591523.

[1] https://hg.mozilla.org/mozilla-central/rev?node=d392d3ba99dd

Comment 1

[Markus Stange [:mstange]]

We are hitting the "unexpected partial update" assertion, probably due to bug 1591758. This crash only affects people who have manually flipped the gfx.webrender.compositor pref.

Comment 2

[Markus Stange [:mstange]]

For crashes with a moz crash reason, e.g. MOZ_RELEASE_ASSERT crashes such as this one, it would be really useful to have the moz crash reason in the bug description - more useful than the stack, in fact. Could you tweak your scripts to include it, ideally above the call stack?

Comment 3

[Calixte Denizet (:calixte)]

:mstange, ok I'll do.

Comment 4

[Markus Stange [:mstange]]

Oh, this was fixed by bug 1591758 in the meantime.