1592935 - Provide a way for testing GV metrics that does not require building Fenix

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

In order to make sure that metrics collected in Gecko are properly exfiltrated through the Glean SDK, we currently need to do the following:

• change Gecko's metrics.yaml;
• build Gecko View;
• point Android Components to the locally build Gecko View;
• publish A-C to the local Maven repository;
• point Fenix to the local Maven repository;
• build Fenix;
• use the debug activity to trigger a ping or log to logcat.

Unfortunately, we cannot simply make the GeckoView example in mozilla-central do that, because some of the heavy lifting happens in the engine-gecko-* components in A-C.

We should probably create a new sample in A-C that uses both GeckoView and Glean to allow testing it, or change the current sample browser to allow this testing.

Comment 1

[Alessio Placitelli [:Dexter]]

Hey Sebastian,

given comment 0, what would you prefer? Would you be ok in adding the Glean SDK as a dependency to the samples-browser application or should we create a new samples-gv-glean ?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Alessio Placitelli [:Dexter] from comment #1)

given comment 0, what would you prefer? Would you be ok in adding the Glean SDK as a dependency to the samples-browser application or should we create a new samples-gv-glean ?

Adding this to sample browser sounds fine to me. Sample browser is primarily our testing application for the engine components. However we added other related components to it because moving them to a separate app may not test them in context or will end up being a "sample browser and X" application.
So as long as this doesn't increase the maintenance burden on the AC team (for example breaking changes that need to be addressed frequently) I think it is totally fine to add this to sample browser.

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Sebastian Kaspari (:sebastian; :pocmo) from comment #2)

So as long as this doesn't increase the maintenance burden on the AC team (for example breaking changes that need to be addressed frequently) I think it is totally fine to add this to sample browser.

No, that shouldn't be the case. We only expect to expose basic functionalities there. If any breaking change shows up, we'll take care of that!

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: GitHub Pull Request

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: sample_browser_data_request.md

Comment 6

[Chris H-C :chutten]

Comment on attachment 9106925 [details]
sample_browser_data_request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in its definitions file [metrics.yaml](https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/components/telemetry/geckoview/streaming/metrics.yaml) as well as in the [Glean SDK's documentation](https://mozilla.github.io/glean/book/user/collected-metrics/metrics.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is controlled by setting upload enabled via the Glean SDK methods. It defaults to false.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Alessio Placitelli is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default off. (Can be turned on for testing)

    Does the instrumentation include the addition of any new identifiers?

Not outside those already documented in the Book of Glean.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 7

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1592935 - Document how to test exfiltrated Gecko metrics in samples-browser. r?janerik

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29e5b37c795d
Document how to test exfiltrated Gecko metrics in samples-browser. r=janerik

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/29e5b37c795d