Closed Bug 1592967 Opened 5 years ago Closed 5 years ago

Reloading out of process iframe resets zoom level

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Project Flags:
Fission Milestone M6

People

(Reporter: enndeakin, Unassigned)

References

(Blocks 2 open bugs)

Details

  1. Enable fission (fission.autostart preference)
  2. Open data:text/html,<html><body>Outer Text<iframe src='http://www.example.com'></iframe></body></html>
  3. Zoom the page.
  4. Reload the page.

Expected: The page is reloaded at the adjusted zoom level.
Actual: The outer page is correct, but the content of the iframe is reset to zoom level 1.

This occurs in both full and text zoom modes.

I suspect that this is because nsDocumentViewer::CallChildren iterates over docshells so doesn't assign the right zoom level to each subframe.

Blocks: rendering-fission
Fission Milestone: --- → ?
Flags: needinfo?(matt.woodrow)
Priority: -- → P2

How does it work when we set the zoom initially? Do you know why we're taking a different path for setting the zoom, vs restoring it on a reload?

Flags: needinfo?(matt.woodrow) → needinfo?(enndeakin)
Fission Milestone: ? → M5

M6 because zooming doesn't block dogfooding.

Fission Milestone: M5 → M6

Moving page zoom bug to Layout.

Component: DOM: Navigation → Layout
Priority: P2 → --
Whiteboard: [layout:triage-discuss]

Looks like it works fine now. Neil, can you please double-check?

Yes, this appears to be fixed. I'm going to close it. Not sure if it was fixed by Emilio's work in bug 1612068?

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Whiteboard: [layout:triage-discuss]

Yes, sounds p. likely.

Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.