1592973 - Fix WebAssembly ABIResultIter for stack arguments

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Andy Wingo [:wingo]]

Iterating in prev() order would barf when it would reach register results, as settleRegister() assumed forward iteration.

Test case (part of an uncommitted patch):

wasmFullPass(`
  (module
    (func (export "run") (result i32)
      (i32.const 32) (i32.const 10)
      (loop (param i32 i32) (result i32 i32))
      (i32.add)))`,
             42);

Comment 1

[Andy Wingo [:wingo]]

Attachment: Bug 1592973 - Fix WebAssembly ABIResultIter for stack arguments

Comment 2

[Andy Wingo [:wingo]]

Attachment: Bug 1592973 - Fix WebAssembly ABIResultIter for stack arguments

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9d567f16757
Fix WebAssembly ABIResultIter for stack arguments r=lth

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a9d567f16757