1593043 - [wpt-sync] Sync PR 20025 - [css-pseudo] Apply ::marker styles to markers

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 20025 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20025
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-pseudo] Apply ::marker styles to markers

Currently markers are assigned a mostly empty style, it just inherits
from the list item and has some customizations like display.

This patch makes them use the style of the ::marker pseudo-element.
The inheritance is also from the list item, and the customizations are
applied afterwards.

The change only affects markers originated by real elements. Markers
originated by ::before or ::after pseudo-elements should get the styles
from ::before::marker or ::after::marker, but this will be addressed in
a follow-up patch.

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html
TEST=external/wpt/css/css-pseudo/marker-color.html
TEST=external/wpt/css/css-pseudo/marker-font-properties.html

Change-Id: Ide2fbc344e4732257044ebd3e7966906af21c434
Reviewed-on: https://chromium-review.googlesource.com/1893265
WPT-Export-Revision: 60b6d74a6c096cf9830fff432eb9222aedef4738

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd142af88ef8f257d57e802444f7f74a30e8b016

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1593043 [wpt PR 20025] - [css-pseudo] Apply ::marker styles to markers, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Apply ::marker styles to markers

Currently markers are assigned a mostly empty style, it just inherits
from the list item and has some customizations like display.

This patch makes them use the style of the ::marker pseudo-element.
The inheritance is also from the list item, and the customizations are
applied afterwards.

The change only affects markers originated by real elements. Markers
originated by ::before or ::after pseudo-elements should get the styles
from ::before::marker or ::after::marker, but this will be addressed in
a follow-up patch.

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html
TEST=external/wpt/css/css-pseudo/marker-color.html
TEST=external/wpt/css/css-pseudo/marker-font-properties.html

Change-Id: Ide2fbc344e4732257044ebd3e7966906af21c434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893265
Reviewed-by: Rune Lillesveen <[e-mail]>
Commit-Queue: Oriol Brufau <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#711883}

--

wpt-commits: e76f87b52667b3e8b43285e72b654bfa7cb8ace9
wpt-pr: 20025

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1593043 [wpt PR 20025] - Update wpt metadata, a=testonly

wpt-pr: 20025
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/276d48081849
[wpt PR 20025] - [css-pseudo] Apply ::marker styles to markers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3f44ee5d89c6
[wpt PR 20025] - Update wpt metadata, a=testonly

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/276d48081849
https://hg.mozilla.org/mozilla-central/rev/3f44ee5d89c6