Closed
Bug 1593119
Opened 5 years ago
Closed 4 years ago
Unifdef MOZ_XBL
Categories
(Core :: XBL, task)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
(Blocks 3 open bugs)
Details
Attachments
(3 files)
To unblock further cleanup, we should remove the now-unused XBL implementation.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
This was generated with:
rg -l -g '*.{cpp,h}' MOZ_XBL . | while read FILE ; do
echo $FILE
unifdef -m -UMOZ_XBL $FILE
done
After this, I manually removed the directive in nsContentUtils.cpp due to:
unifdef: ./dom/base/nsContentUtils.cpp: 4630: Unterminated string literal
unifdef: Output may be truncated
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D51337
Assignee | ||
Comment 3•5 years ago
|
||
This looks good on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=abd692a8ba361e71a4b68c03606bde8949244172
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D51337
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd79491d6061 unifdef MOZ_XBL r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/1fff2450c69f clang-format the files affected by the MOZ_XBL unifdef r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/def5ec4549e7 Remove dom/xbl and the MOZ_XBL build option r=bzbarsky
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd79491d6061
https://hg.mozilla.org/mozilla-central/rev/1fff2450c69f
https://hg.mozilla.org/mozilla-central/rev/def5ec4549e7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•