1593203 - UBSan: load of value 228, which is not a valid value for type 'const bool' [@ mozilla::dom::MediaStateDebugInfo::ToObjectInternal]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

See https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=273989532&revision=61e3171ca18e457914b4230d59b25ce6f91b7d57

An error TEST-UNEXPECTED-FAIL | dom/media/test/test_playback.html | flac-sample.mp4 should not fire 'error' event NS_ERROR_DOM_MEDIA_DECODE_ERR (0x806e0004) - virtual mozilla::MediaResult mozilla::FFmpegAudioDecoder<46465650>::DoDecode(mozilla::MediaRawData *, uint8_t *, int, bool *, mozilla::MediaDataDecoder::DecodedData &): FFmpeg audio error:-1094995529 leads to a call to the privileged method HTMLMediaElement.mozRequestDebugInfo, which in a MozPromise resolve handlers hits this issue.

The resolve handler was written in bug 1542674.

The relevant log output is

[task 2019-10-31T22:44:47.455Z] 22:44:47 INFO - GECKO(2061) | /builds/worker/workspace/build/src/obj-firefox/dom/bindings/MediaDebugInfoBinding.cpp:2249:21: runtime error: load of value 228, which is not a valid value for type 'const bool'
[task 2019-10-31T22:44:47.940Z] 22:44:47 INFO - GECKO(2061) | #0 0x7f480768b813 in mozilla::dom::MediaStateDebugInfo::ToObjectInternal(JSContext*, JS::MutableHandle<JS::Value>) const /builds/worker/workspace/build/src/obj-firefox/dom/bindings/MediaDebugInfoBinding.cpp:2249:21
[task 2019-10-31T22:44:47.941Z] 22:44:47 INFO - GECKO(2061) | #1 0x7f480769ad7e in mozilla::dom::MediaFormatReaderDebugInfo::ToObjectInternal(JSContext*, JS::MutableHandle<JS::Value>) const /builds/worker/workspace/build/src/obj-firefox/dom/bindings/MediaDebugInfoBinding.cpp:3974:23
[task 2019-10-31T22:44:47.942Z] 22:44:47 INFO - GECKO(2061) | #2 0x7f48076af920 in mozilla::dom::MediaDecoderDebugInfo::ToObjectInternal(JSContext*, JS::MutableHandle<JS::Value>) const /builds/worker/workspace/build/src/obj-firefox/dom/bindings/MediaDebugInfoBinding.cpp:6115:23
[task 2019-10-31T22:44:47.943Z] 22:44:47 INFO - GECKO(2061) | #3 0x7f48076b28f1 in mozilla::dom::HTMLMediaElementDebugInfo::ToObjectInternal(JSContext*, JS::MutableHandle<JS::Value>) const /builds/worker/workspace/build/src/obj-firefox/dom/bindings/MediaDebugInfoBinding.cpp:6366:23
[task 2019-10-31T22:44:47.977Z] 22:44:47 INFO - GECKO(2061) | #4 0x7f4809f8d369 in ToJSValue<mozilla::dom::HTMLMediaElementDebugInfo> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/ToJSValue.h:252:20
[task 2019-10-31T22:44:47.979Z] 22:44:47 INFO - GECKO(2061) | #5 0x7f4809f8d369 in ToJSValue<mozilla::dom::HTMLMediaElementDebugInfo > /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/ToJSValue.h:319:10
[task 2019-10-31T22:44:47.980Z] 22:44:47 INFO - GECKO(2061) | #6 0x7f4809f8d369 in MaybeSomething<mozilla::dom::HTMLMediaElementDebugInfo > /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Promise.h:298:10
[task 2019-10-31T22:44:47.981Z] 22:44:47 INFO - GECKO(2061) | #7 0x7f4809f8d369 in void mozilla::dom::Promise::MaybeResolve<mozilla::dom::HTMLMediaElementDebugInfo>(mozilla::dom::HTMLMediaElementDebugInfo&&) /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Promise.h:84:5
[task 2019-10-31T22:44:47.982Z] 22:44:47 INFO - GECKO(2061) | #8 0x7f480a00ba63 in operator() /builds/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:1741:24
[task 2019-10-31T22:44:47.983Z] 22:44:47 INFO - GECKO(2061) | #9 0x7f480a00ba63 in InvokeMethod<(lambda at /builds/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:1740:13), void ((lambda at /builds/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:1740:13)::)() const, bool> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:520:12
[task 2019-10-31T22:44:47.984Z] 22:44:47 INFO - GECKO(2061) | #10 0x7f480a00ba63 in InvokeCallbackMethod<false, (lambda at /builds/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:1740:13), void ((lambda at /builds/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:1740:13)::)() const, bool, RefPtr<mozilla::MozPromise<bool, nsresult, true>::Private> > /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:544:5
[task 2019-10-31T22:44:47.986Z] 22:44:47 INFO - GECKO(2061) | #11 0x7f480a00ba63 in mozilla::MozPromise<bool, nsresult, true>::ThenValue<mozilla::dom::HTMLMediaElement::MozRequestDebugInfo(mozilla::ErrorResult&)::$_0, mozilla::dom::HTMLMediaElement::MozRequestDebugInfo(mozilla::ErrorResult&)::$_1>::DoResolveOrRejectInternal(mozilla::MozPromise<bool, nsresult, true>::ResolveOrRejectValue&) /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:726:9
[task 2019-10-31T22:44:47.990Z] 22:44:47 INFO - GECKO(2061) | #12 0x7f48054932a2 in mozilla::MozPromise<bool, nsresult, true>::ThenValueBase::ResolveOrRejectRunnable::Run() /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:402:21
[task 2019-10-31T22:44:47.990Z] 22:44:47 INFO - GECKO(2061) | #13 0x7f480358eef6 in mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run() /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/TaskDispatcher.h:197:35
[task 2019-10-31T22:44:47.991Z] 22:44:47 INFO - GECKO(2061) | #14 0x7f480358b522 in mozilla::EventTargetWrapper::Runner::Run() /builds/worker/workspace/build/src/xpcom/threads/AbstractThread.cpp:113:25
[task 2019-10-31T22:44:47.992Z] 22:44:47 INFO - GECKO(2061) | #15 0x7f4803584cb1 in mozilla::SchedulerGroup::Runnable::Run() /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:295:32
[task 2019-10-31T22:44:48.008Z] 22:44:48 INFO - GECKO(2061) | #16 0x7f48035b1d73 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1225:14
[task 2019-10-31T22:44:48.008Z] 22:44:48 INFO - GECKO(2061) | #17 0x7f48035b88d1 in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:486:10

Comment 1

[Andreas Pehrson [:pehrsons]]

Tarek, can you take a look?

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Likely too late for a fix in 70.

Comment 3

[Tarek Ziadé (:tarek)]

I think it's because of an int/bool type mismatch, for mWaitingForKey or mWaitingForData

I will fix the type and run an ASAN try to see if that fixes it

Comment 4

[Tarek Ziadé (:tarek)]

try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=af9885d7e1757afe95d52bb20ecf80eb1feec93a

Comment 5

[Tarek Ziadé (:tarek)]

Attachment: Bug 1593203 - Proper initialization of nested dictionaries for MediaDebugInfo.webidl r?pehrsons,bz

mWaitingForKey and mWaitingForData are boolean values, not integers

Comment 6

[Tarek Ziadé (:tarek)]

full mda try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac45a8e6a7f04d9b0c1895a5c61cb847fe13876

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a04cf95c417d
Proper initialization of nested dictionaries for MediaDebugInfo.webidl  r=pehrsons,bzbarsky

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a04cf95c417d

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Tarek, is that a patch you think we could safely uplift to 71 beta or should it ride the 72 train? Thanks

Comment 10

[Tarek Ziadé (:tarek)]

I think it's safe to uplfit.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

We talked on IRC about it and there was no strong benefit for us to uplift in 71, we can let it ride the trains.