Open Bug 1593213 Opened 6 years ago Updated 3 years ago

Missing code value for Redo, New, Close, Reply, Fw, Send and Save

Categories

(Core :: DOM: Events, task)

Product:
Core
Component:
DOM: Events
Version:
70 Branch
Platform:
Desktop
All
Type:
task

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: ossman, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Press the Redo key

Actual results:

I got an event where code was empty.

Expected results:

I got an event where code was set to "Redo".

Can you provide more details about those keys?
are they physical keys on your keyboard?

Component: Untriaged → DOM: Events
Flags: needinfo?(ossman)
Product: Firefox → Core

Yup. They're available on the fairly common Microsoft Ergonomic Keyboard 4000. They share the same physical keys as F1-F12 and are accessible by toggling "F lock".

It's not a pressing need for us at this point. We were testing the keyboard handling in noVNC and are trying to report all issues found, even if we don't have any user reports (yet).

Flags: needinfo?(ossman)

IIRC, they don't have individual scancode values and the spec never defines them.

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID

Huh? They definitely have unique scan codes. And if the spec doesn't define them, then it needs to be updated. The values are in the key specification, so it's only natural that the code specification should include their corresponding physical keys.

At the very least code should never be empty. It should be 'Unidentified' if you don't have a good mapping.

(In reply to Pierre Ossman from comment #4)

Huh? They definitely have unique scan codes.

Really? If so, the spec should have them. But I couldn't see individual scancodes for them when I contributed the spec.

At the very least code should never be empty. It should be 'Unidentified' if you don't have a good mapping.

Yes, it's bug 1264150. If Chromium fixes their bug, we'll follow it.

Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
OS: Unspecified → All
Hardware: Unspecified → Desktop

Per comment #5, mark for duplication.

Status: UNCONFIRMED → RESOLVED
Type: defect → task
Closed: 6 years ago → 6 years ago
Resolution: --- → DUPLICATE

Hang on there, bug 1264150 is just for the 'Unidentified' bit, i.e. the very bare minimum. This bug should be left open to handle these keys properly. (which probably requires work upstream in the specification as well)

As for the scan codes, on Linux it is KEY_REDO, KEY_NEW, KEY_CLOSE, etc. In XKB they end up in the generically name I*** range.

I have not investigated Windows as media keys are a random mess over there.

Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.