1593217 - 0.35 - 225.61% compiler_metrics num_static_constructors / installer size (*) regression on push 3a458217248db4f5a1f9d18480aea606006959aa (Thu October 31 2019)

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Marian Raiciof [:marauder]]

0.35 - 225.61% compiler_metrics num_static_constructors / installer size (android-4-0-armv7-api16, android-4-2-x86, android-5-0-aarch64, android-5-0-x86_64, linux32, linux32-shippable, linux64, linux64-noopt, linux64-shippable, osx-cross, osx-shippable, windows2012-32, windows2012-64, windows2012-64-shippable, windows2012-aarch64) regression on push 3a458217248db4f5a1f9d18480aea606006959aa (Thu October 31 2019)

---

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=3a458217248db4f5a1f9d18480aea606006959aa

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

226% compiler_metrics num_static_constructors android-5-0-aarch64 opt 82.00 -> 267.00
226% compiler_metrics num_static_constructors android-5-0-aarch64 pgo 82.00 -> 267.00
226% compiler_metrics num_static_constructors android-5-0-x86_64 opt 82.00 -> 267.00
223% compiler_metrics num_static_constructors android-4-0-armv7-api16 opt 83.00 -> 268.00
223% compiler_metrics num_static_constructors android-4-0-armv7-api16 pgo 83.00 -> 268.00
197% compiler_metrics num_static_constructors osx-shippable opt 93.00 -> 276.00
176% compiler_metrics num_static_constructors linux64 opt valgrind 102.00 -> 282.00
175% compiler_metrics num_static_constructors linux32-shippable opt 102.00 -> 281.00
175% compiler_metrics num_static_constructors linux64-shippable opt 102.00 -> 281.00
174% compiler_metrics num_static_constructors linux64 opt 103.00 -> 282.00
171% compiler_metrics num_static_constructors windows2012-64-shippable opt 105.00 -> 285.00
171% compiler_metrics num_static_constructors windows2012-aarch64 opt aarch64 105.00 -> 285.00
171% compiler_metrics num_static_constructors windows2012-aarch64 opt aarch64-no-eme 105.00 -> 285.00
170% compiler_metrics num_static_constructors windows2012-32 opt 106.00 -> 286.00
170% compiler_metrics num_static_constructors windows2012-64 opt 106.00 -> 286.00
168% compiler_metrics num_static_constructors linux64 opt base-toolchains-clang 106.00 -> 284.00
142% compiler_metrics num_static_constructors linux64 opt base-toolchains 124.00 -> 300.00
126% compiler_metrics num_static_constructors android-4-0-armv7-api16 debug 127.00 -> 287.00
126% compiler_metrics num_static_constructors android-5-0-aarch64 debug 127.00 -> 287.00
126% compiler_metrics num_static_constructors android-5-0-x86_64 debug 127.00 -> 287.00
125% compiler_metrics num_static_constructors android-4-2-x86 debug 129.00 -> 290.00
116% compiler_metrics num_static_constructors osx-cross debug 140.00 -> 302.00
115% compiler_metrics num_static_constructors osx-cross debug fuzzing 142.00 -> 305.00
110% compiler_metrics num_static_constructors windows2012-32 debug 147.00 -> 308.00
110% compiler_metrics num_static_constructors windows2012-64 debug 147.00 -> 308.00
109% compiler_metrics num_static_constructors windows2012-aarch64 debug aarch64 148.00 -> 309.00
109% compiler_metrics num_static_constructors windows2012-64 debug fuzzing 149.00 -> 311.00
105% compiler_metrics num_static_constructors android-5-0-x86_64 debug gcp 127.00 -> 260.33
103% compiler_metrics num_static_constructors linux32 debug 153.00 -> 310.00
103% compiler_metrics num_static_constructors linux64 debug 153.00 -> 310.00
101% compiler_metrics num_static_constructors linux64 debug base-toolchains-clang 155.00 -> 311.00
96% compiler_metrics num_static_constructors osx-cross debug gcp 140.00 -> 275.00
94% compiler_metrics num_static_constructors linux64 debug gcp 153.00 -> 296.92
86% compiler_metrics num_static_constructors linux32 debug gcp 153.00 -> 283.83
39% compiler_metrics num_static_constructors linux64 debug base-toolchains 271.00 -> 377.00
39% compiler_metrics num_static_constructors linux64 debug fuzzing 275.00 -> 382.00
39% compiler_metrics num_static_constructors linux64-noopt debug 273.00 -> 379.00
0.35% installer size osx-shippable opt nightly 80,934,333.25 -> 81,216,210.33

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23618

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Marian Raiciof [:marauder]]

I'll mark it as fixed because it was backed out on

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d8059472045b0b003ac4fe837984e8b7db96707&tochange=1efec06dae2fc6c25b4f0ca1365c01e4b470023f

and the graph returned to normal.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Move const nsCString into *.cpp. r=mayhemer

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

For the record, I reassigned alert 23657 here because this was reopened, but technically might not be the same alert (it was backed out and landed again, so it might be a different context).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbdabe556416
Move const nsCString into *.cpp. r=mayhemer

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fbdabe556416