Closed Bug 1593247 Opened 5 years ago Closed 5 years ago

Fix WebAssembly Ion codegen for if/then without else

Categories

(Core :: JavaScript: WebAssembly, defect, P3)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Bug 1593247 - Fix WebAssembly Ion codegen for if/then without else
47 bytes, text/x-phabricator-request
Details | Review

Test case (to be committed):

  (module
    (func (export "run") (result i32)
      (i32.const 32)
      (i32.const 10)
      (i32.const 1)
      (if (param i32 i32) (result i32 i32)
          (then
            (drop)
            (drop)
            (i32.const 10)
            (i32.const 32)))
      (i32.sub)))

Basically Ion wasn't getting passed the DefVector corresponding to the results of the missing "else" block.

Priority: -- → P3
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fdca8fd9f68e Fix WebAssembly Ion codegen for if/then without else r=luke

https://hg.mozilla.org/mozilla-central/rev/fdca8fd9f68e

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: