Closed Bug 1593247 Opened 8 months ago Closed 8 months ago

Fix WebAssembly Ion codegen for if/then without else

Categories

(Core :: Javascript: WebAssembly, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Test case (to be committed):

  (module
    (func (export "run") (result i32)
      (i32.const 32)
      (i32.const 10)
      (i32.const 1)
      (if (param i32 i32) (result i32 i32)
          (then
            (drop)
            (drop)
            (i32.const 10)
            (i32.const 32)))
      (i32.sub)))

Basically Ion wasn't getting passed the DefVector corresponding to the results of the missing "else" block.

Priority: -- → P3
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fdca8fd9f68e
Fix WebAssembly Ion codegen for if/then without else r=luke
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.