1593322 - Update Sign up tile on Awesomescreen to avoid awkward line break

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[mheubusch]

Sean Martell will upload recommended changes to avoid a line break that puts a link on two lines.

Comment 1

[Sean Martell]

Attachment: Spec clarification

To avoid a line break, please ensure there's no right/left margin affecting the content at the button section of the layout. Would involve ensuring the margins of the above content don't continue to the CTA area.

One other edit would be to left align the blurb of text preceding the button as shown in the spec.

Thanks!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:st3fan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1593322 - Allow the sign-in text to be as wide as the parent; r?AndreiLazar

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Updated sign-in.png

The easy solution would be to just allow that row containing the sign-in link to be as wide as the parent.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9110768 [details]
Bug 1593322 - Allow the sign-in text to be as wide as the parent; r?AndreiLazar

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Important UX issue for a high priority UI element.
• User impact if declined: UX issue - Possible line break of a hyperlink
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change.
• String or UUID changes made by this patch:

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9110768 [details]
Bug 1593322 - Allow the sign-in text to be as wide as the parent; r?AndreiLazar

Tweak to layout, OK for uplift for Fennec 68.3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/33662046802c

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed on ESR builds 68.3b6, 68.3a1.
Devices: Google Pixel (Android Q), Samsung Galaxy Tab S3 (Android 8.0).

However, for the "Sign up" button, the shadow now seems to be missing.

Comment 9

[Sorina Florean [:sflorean]]

Confirming the fix as well on 68.3.0 RC.