1593339 - Remove unneeded "vibrancy fill color" drawing

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P3)

Description

[Markus Stange [:mstange]]

We currently render mostly-translucent "vibrancy fill colors" on top of vibrant areas of the window. Drawing these fill colors was necessary in the past because we were erasing the fill color that was drawn by the system, through our override of the drawRect method of our NSVisualEffectView subclass.

However, starting with changeset be263e3d8bdfc0b6c072ffad2736999b9652d036 (from bug 1491445), we no longer override drawRect. Moreover, since the switch to Core Animation, there is no way to clear the system's vibrancy fill drawing.

So we don't need to draw the vibrancy fill color any more. In fact, we should stop drawing it, because now we're double-drawing it.
The fill color is very translucent so the double-drawing is not visually obvious.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1593339 - Stop drawing vibrancy background colors. r=spohl

Drawing vibrancy fill colors was necessary in the past because we were erasing
the fill color that was drawn by the system, through our override of the
drawRect method of our NSVisualEffectView subclass.

However, starting with changeset be263e3d8bdfc0b6c072ffad2736999b9652d036
(from bug 1491445), we no longer override drawRect. Moreover, since the switch
to Core Animation, there is no way to clear the system's vibrancy fill drawing.

So we don't need to draw the vibrancy fill color any more. In fact, we should
stop drawing it, because now we're double-drawing it.
The fill color is very translucent so the double-drawing is not visually obvious.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1593339 - Remove now-unused vibrancy fill color methods. r=spohl

Depends on D51456

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1975423d6915
Stop drawing vibrancy background colors. r=spohl
https://hg.mozilla.org/integration/autoland/rev/6aaeed171a39
Remove now-unused vibrancy fill color methods. r=spohl

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1975423d6915
https://hg.mozilla.org/mozilla-central/rev/6aaeed171a39