1593343 - Marionette should not be enabled if no MOZ_MARIONETTE environment variable is set nor the --marionette argument specified

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marionette should only be started when the MOZ_MARIONETTE environment variable is set, or the --marionette argument is specified when starting Firefox.

Right now we save the Marionette enabled state in the preference marionette.enabled, which will never be reset. As such a next start of Firefox without those two methods will still cause Marionette to be enabled.

Comment 1

[Rishi Gupta (:rgpt)]

@Whimboo, I wish to work on this bug.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sure. As usual let me know if you need more information. Thanks

Comment 3

[Rishi Gupta (:rgpt)]

Attachment: Bug 1593343 - [marionette] Marionette should not be enabled if niether set in the environment nor passed through command line arguments r=whimboo

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I think that I should care about it. Will have a look within the next days.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We probably can get rid of this preference, and work for that needs to be done on bug 1632821. If that's the case it will also fix this bug.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1593343 - [telemetry] Stop recording of the "marionette.enabled" preference.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1593343 - [condprof] Remove usage of "marionette.enabled".

Depends on D107196

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1593343 - [marionette] Remove preference "marionette.enabled".

Depends on D107197

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c09023d5bd1
[telemetry] Stop recording of the "marionette.enabled" preference. r=chutten
https://hg.mozilla.org/integration/autoland/rev/2650e8bbdad0
[condprof] Remove usage of "marionette.enabled". r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/a32e1c5c8ad8
[marionette] Remove preference "marionette.enabled". r=marionette-reviewers,jdescottes

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c09023d5bd1
https://hg.mozilla.org/mozilla-central/rev/2650e8bbdad0
https://hg.mozilla.org/mozilla-central/rev/a32e1c5c8ad8