1593347 - Searching in "all address books" doesn't show any results from LDAP

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[Kai Engert (:KaiE:)]

This is a regression in TB 72 nightly. It works when using TB 68.

• Configure the Adams LDAP server as described in bug 1574712 comment #0
• Keep SSL disabled, to demonstrate that this bug is independent of using SSL.
• Open address book. Keep the left hand side default selection, which is "all address books".
• Type a name into the search field, e.g. "Alvarez" and hit enter.
• Wait a few seconds

The bug is that no results are shown.

As a counter example that still works: On the left hand side, explicitly select the configured Adams LDAP directory and repeat the search. That still works.

(Originally reported in bug 1576364 comment 51, but should be tracked independently, because it's separate from SSL.)

Comment 1

[Wayne Mery (:wsmwk)]

so doesn't exist in 71 beta?

Comment 2

[Jorg K (CEST = GMT+2)]

Alice, you're familiar with the LDAP setup, could you please find the regression for us.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e7476e934b191ffac787208323191c9c034049ce&tochange=72b1cec1260e68511a8b99d0e72fd8b0cefd44dc
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3fa65bda1e506a314ea90d936f763c7e840ab98a&tochange=3fa65bda1e506a314ea90d936f763c7e840ab98a

Comment 4

[Jorg K (CEST = GMT+2)]

Thank you so much, Alice. I suspected that. Also broken in TB 71.

Comment 5

[Alice0775 White]

Strange thing.
I cannot reproduce the issue with New profile on Daily72.0a1(Build ID 20191101101931) Windows10 and TB71.0b1(Build ID 20191024110308) windows10.

However, after once restart TB, It does not work any more.
So, this is something profile is damaged when restart TB.

Comment 6

[Jorg K (CEST = GMT+2)]

Sure, the bugs in the range you found are related to converting the address books from MAB formar to SQLite format, see:
https://www.thunderbird.net/en-US/thunderbird/71.0beta/releasenotes/ - third item.

Thanks again!

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1593347-ldap-search-results-1.diff

This is the most time I've wasted on what turned out to be such a minor fix for a while. As a bonus, in this patch I've re-enabled some tests that I noticed actually pass now that JS is the default provider.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9106817 [details] [diff] [review]
1593347-ldap-search-results-1.diff

Great, this fixes the "stuck case" I had after migration. Even better that the tests pass now.

Comment 9

[Geoff Lankow (:darktrojan)]

Just to be crystal clear, the tests passed before, they just weren't enabled.

Comment 10

[Geoff Lankow (:darktrojan)]

Just to be clear, the tests passed before, they just weren't enabled.

Comment 11

[Jorg K (CEST = GMT+2)]

Sure, sorry I didn't express it properly: Even better that (in the course of looking at this you discovered that) the test pass now ;-)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad2a01d029a8
Fix LDAP address book search results. r=jorgk DONTBUILD

Comment 13

[Jorg K (CEST = GMT+2)]

TB 71 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/f28c010aac310532478294838f0c4ae9d988c9c8