1593366 - Select popup shows up on keydown even when event is default prevented.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[marioposilva]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Focus hidden tag select and press spacebar key.

(Select css:
select {
position: absolute;
bottom: 0;
left: 50%;
display: inline-block;
width: 0;
height: 0;
padding: 0;
opacity: 0;
border: none;
overflow:hidden;
}
)

Actual results:

The hidden select shows the dropdown options.

Expected results:

Dropdown options should remain hidden.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Could you attach an HTML page that shows the bug? Also why is this the expected result? If it is focusable, I'd expect the user to be able to use it.

Comment 3

[marioposilva]

Attachment: Html code with jquery and some CSS

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)
> Could you attach an HTML page that shows the bug? Also why is this the expected result? If it is focusable, I'd expect the user to be able to use it.

Comment 4

[marioposilva]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Could you attach an HTML page that shows the bug? Also why is this the expected result? If it is focusable, I'd expect the user to be able to use it.

You can test it on Chrome and Firefox, in Chrome, if you press TAB > Spacebar, it will open the masked dropdown and won't show the native dropdown.
When doing it on Firefox, it will show the native dropdown.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Ah, cool, so the issue is that we show the dropdown even if you call e.preventDefault(). I agree that's a bug, but it doesn't have to do with being hidden or not :)

Comment 6

[Emilio Cobos Álvarez [:emilio]]

So a reduced test-case would be: data:text/html,<select onkeydown="return false"><option>Foo</option><option>Bar</option></select>.

That doesn't show the dropdown in other browsers, but it does in Firefox.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1593366 - Check default prevented status in nsListControlFrame::KeyDown. r=mats

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90da3a622fbf
Check default prevented status in nsListControlFrame::KeyDown. r=mats

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/90da3a622fbf