1593383 - Fix REFTEST failures with partial present

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When partial present is enabled, reftests were failed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b90e9134d55631b007bffc8630e953eb35662f

It might be caused by how to taking a snap shot.

Comment 1

[Sotaro Ikeda [:sotaro]]

LayerManagerComposite does full rendering for taking a snapshot.
https://searchfox.org/mozilla-central/source/gfx/layers/composite/LayerManagerComposite.cpp#598

LayerManagerMLGPU also does full rendering for taking a snapshot.
https://searchfox.org/mozilla-central/source/gfx/layers/mlgpu/LayerManagerMLGPU.cpp#511

Comment 2

[Sotaro Ikeda [:sotaro]]

full rendering seemed to address the failures.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef1c30783a346263cd0b2eb6104fef3261fd0957

Comment 3

[Markus Stange [:mstange]]

I agree, doing what our old code did seems like the right way to go here.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1593383 - Force full rendering to external target

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=edc32a56dff55565b29e36ef4e5c4b94194b17b0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e1945e590ff
Force full rendering to external target r=nical,gw

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2e1945e590ff