Closed Bug 1593486 Opened 8 months ago Closed 8 months ago

Add ./mach jit-tests command

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

Details

Attachments

(3 files)

The only way to trigger jit-tests currently with mach is to use the full check-spidermonkey command and it also does not allow selecting specific tests.

This patch add |./mach jit-tests| and runs similar to |./mach jstests|. Arguments can be passed to this command such as to select specific tests or control which jits.

To use this command, you must use 'mach build' with either |ac-add-options --enable-js-shell| or |ac-add-options --enable-application=js|. The second will build just the shell without the browser.

This allows running the jit_tests.py harness using mach. It works very
similarly to the existing 'mach jstests' command.

This also removes the unused (and busted) '--valgrind' flag from the
check-spidermonkey target.

Standardize the jsapi-tests logic to match the other spidermonkey check
commands in testing/mach_commands.py.

Depends on D51518

Attachment #9106015 - Attachment description: Bug 1593486 - Add ./mach jit-tests command → Bug 1593486 - Add ./mach jit-test command
Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c7bc82787c0
Add ./mach jit-test command r=sfink,froydnj
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e50698ac5d2
Cleanup ./mach jsapi-tests implementation r=sfink,froydnj

Remove some overly clever code and make the spidermonkey-related tests more
consistent with eachother.

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e505f5da731
Cleanup spidermonkey test code in mach. r=froydnj
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.