1593537 - Lightning's Today Pane "Mini-Month" dates are wrongly aligned with days of week

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Ronan Jouchet]

Attachment: screenshot_lightning71.0b2-incorrect-minimonth_2019-11-03-13:14:07.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

1. Using Tb 71.0b2-20191030211447 with bundled Lightning 71.0b2
2. View -> Today Pane -> Show Today Pane, Show Mini-Month
3. In Preferences -> Calendar, set "Start the week on" to Monday
4. Look at the Mini-Month
5. Click the "Go to today" button (the circle at the top right of the Mini-Month)

Actual results:

Lightning incorrectly the Mini-Month matrix, mis-aligning days of week (Monday to Sunday) with dates (1, 2, 3, ... 31).

For example, today is Sunday November 3 but, in the Mini-Month widget, today appears as Sunday November 2! It feels like Lightning is confused about Monday as first day of week, maybe? See attached screenshot.

Also, if I click on "Go to today" (the circle button at the top-right of the Mini-Month widget), Lightning incorrectly focuses tomorrow! (the incorrect "Monday 3 Nov")

Expected results:

Lightning should render a correct Mini-Month.

Comment 1

[Ronan Jouchet]

Additional data point: fiddling with the current month and coming back to Today fixes / works around the issue. So,

1. Launch Thunderbird. → Mini-month is broken, with 1day mis-alignment between days and dates
2. Click One Month Forward (the arrow at the next of the current month, atop the mini-month)
3. Click Go To Today → Mini-month is now fixed, properly aligned between days and dates.

Comment 2

[Ronan Jouchet]

Bug still reproducible in Tb 71.0b3-20191113091023 and Lightning 71.0b3

Comment 3

[Ronan Jouchet]

Bug still reproducible in Tb 71.0b4-20191125214250 and Lightning 71.0b4

Comment 4

[Richard Marti (:Paenglab)]

Confirmed, I see this too with trunk: today, Saturday the 30.11. is shown in the Sunday column. This happens only with Monday as start of week day.

What I've also observed is, that when I change the start day, the week day column in the minimonth is immediately updated but not the dates itself.

Comment 5

[Mike Cloaked]

Confirmed for Thunderbird Version 71.0b4 Build ID 20191125214250.

It would be good to see this fixed soon since it could lead to some problems getting to, or planning, events on the wrong day.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1593537-minimonth-update-1.diff

Appears to be my fault. Sorry about that.

Comment 7

[Paul Morris [:pmorris]]

Comment on attachment 9112797 [details] [diff] [review]
1593537-minimonth-update-1.diff

Review of attachment 9112797 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, confirmed that it fixes the problem.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb6662974cc8
Update minimonths when the start of week pref or the week numbers pref changes; r=pmorris

Comment 9

[Geoff Lankow (:darktrojan)]

73 needed.

Comment 10

[Geoff Lankow (:darktrojan)]

72 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/0c85c036df70558655f3e15d8d052935074f7e9f

Comment 11

[Ronan Jouchet]

Confirmed fixed in Tb 72.0b2-20191212014636 + Lightning 72.0b2.
Thanks!

Comment 12

[Ronan Jouchet]

Attachment: lightning-create-event-fails-to-update-events-listview.gif

Geoff, should a similar patch be applied to force an update of the Events listview when a calendar event is added at a particular date picked in the Mini-Month?

STR below and GIF attached, pls tell me if I should I create a new bug.

1. Click a day in the Mini-Month, say 2019-12-18.
2. The "Events listview" (the list below the Mini-Month, listing events for that particular day) shows the events for that day. All good so far.
3. Click "New Event", fill event info leaving the (pre-selected) currently active date (2019-12-18), save.

→ Expected: Events listview listing events for 2019-12-18 should update with the new event created at that date
→ Actual: Events listview does not update, failing to list the event just added.
Workaround A forcing a listview update: collapse/expande the day in the Events list view
Workaround B forcing a listview update: click another day in the Mini-month and re-click the day of the new event

Comment 13

[Geoff Lankow (:darktrojan)]

You should definitely file a new bug. As a general rule, one issue per bug.

I think I can see why that might happen if there's been a timezone change, otherwise I'm not really sure at this stage.

Comment 14

[Ronan Jouchet]

(In reply to Geoff Lankow (:darktrojan) from comment #13)

You should definitely file a new bug. As a general rule, one issue per bug.

I think I can see why that might happen if there's been a timezone change, otherwise I'm not really sure at this stage.

Alright, filed Bug 1605601 - "Newly-created event fails to appear in the Events sidebar listview"