1593553 - Allowing redirection button does nothing

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1414425 added a principal and changed the order of the forceRefreshURI params. It was backported to 2.53. The version for ESR52 retains the order and makes the parameter optional but given the fact that we are closer to 2.57 with 2.53 we should pick thr later patch for security.

Currently The button trying to dismiss the notification results in nothing. The following erros is shown:

Timestamp: 10/31/2019, 2:13:12 AM
Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIRefreshURI.forceRefreshURI]
Source File: chrome://communicator/content/bindings/notification.xml
Line: 288

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1593553-refreshURI.patch

Use a null parameter as in Firefox which uses the triggering principal of the document then.

[Approval Request Comment]
Regression caused by (bug #): 1414425
User impact if declined: Notificantion dismissal and refresh do not work.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9106067 [details] [diff] [review]
1593553-refreshURI.patch

[Triage Comment]
r/a=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83fafd4f19eb
Use null (document) triggering pricipal when refreshing URI. r=IanN DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/b17101745e4aec9ee1c98b8d36f21cd023913812

Comment 5

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8520fe87fdee3dae2a391110fb7b314b2ede747f