1593585 - Letterboxing and findbar inconsistencies [part 2]

Status: RESOLVED DUPLICATE of bug 1591054

(Core :: Window Management, defect, P3)

Description

[Thorin [:thorin]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Not sure if a dupe of bug 1591054 (I think it is the same underlying cause) but will file this separately

STR:

• enable RFP and letterboxing (LB)
• load two web pages in the same window
• make the letterbox height margins small enough to trigger a LB step
• toggle the findbar on site A only
• inspect both pages (they have changed)
• close site A tab
• inspect both pages
• note: as soon as the next tab is opened, all tabs seem to get recalculated

Actual

• site B stays at the new LB caused by the findbar

Expected

• toggling the findbar off never triggered the LB re-calculations, because it never happened, instead the tab itself was closed

Solution

• trigger LB on tab close ? see note above where it seems to be reapplied universally (by window) on new tab

Extra

• You can change the STR order around. E.g. open the site B after toggling the findbar on site A, and site B will use a different height (correctly stepped in this case). So I think this, and bug 1591054 are showing that the LB change from findbar needs to be applied per tab only, or something.

Comment 1

[Thorin [:thorin]]

This solved by

• https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32308 - Stop inner letterbox jiggling as border is dragged
  • to be clear, I still get jitter, but this is the parent ticket
• https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests/480 - use direct browser sizing for letterboxing

Additionally solved

• https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41515 - Letterboxing can change by a few px unnecessarily when opening find bar
  • i.e when there is no need for it because the bottom matte is already large enough to accommodate the findbar chrome

By using css grid, the findbar now only applies to each tab

Closing as duplicate of Bug 1591054