1593712 - `moz-phab --no-arc` should fail on non-cinnabar git clones of hg hosted repos (such as mozilla-central)

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

And that makes some potential contributors attach their patches to bugzilla, as in bug 1208906.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I suggested running moz-phab --no-arc insted, and the contributor said it did help.

Comment 2

[Piotr Zalewa [:zalun]]

Creating new revision:
91d8ecd50fe8 Bug 1208906 - Remove an unnecessary conditional;r=ehsan,jmathies
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 Exception
ERR-CONDUIT-CORE: Local VCS (git) is different from the one defined in the repository (hg).
To use Phabricator with git-cinnabar please follow the docs at https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#using-git-cinnabar
(Run with `--trace` for a full exception trace.)
CommandError: command '/Users/my_user_name/.mozbuild/moz-phab/arcanist/bin/arc' failed to complete successfully

User had no Git Cinnabar installed and wanted to submit to a Merurial repo using git.
This should fail with or without --no-arc before submitting - further investigation is needed.

Comment 3

[:glob ✱]

cinnabar is required to use git to submit to a mercurial repository on phabricator (such as mozilla-central), so it's important for this check to be present in moz-phab when required.

cinnabar isn't required to work on pure git repositories.

Comment 4

[Piotr Zalewa [:zalun]]

Attachment: Bug 1593712 - Fail early if cinnabar is required, but not installed. r=glob