Closed
Bug 1593793
Opened 5 years ago
Closed 5 years ago
Move and rename nsPrintData::mBrandName to nsPrintJob::mFallbackDocTitle
Categories
(Core :: Printing: Setup, enhancement, P3)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
(Whiteboard: [print2020_v72])
Attachments
(1 file)
nsPrintData::mBrandName never changes over the lifetime of a Firefox instance. It is wasteful to have nsPrintData obtain and store it, since we can replace an nsPrintJob's nsPrintData object multiple times over the lifetime of the nsPrintJob, and nsPrintJob is the only consumer.
|
Assignee | |
Comment 1•5 years ago
|
||
nsPrintData::mBrandName never changes over the lifetime of a Firefox instance.
It is wasteful to have nsPrintData obtain and store it, since we can replace
an nsPrintJob's nsPrintData object multiple times over the lifetime of the
nsPrintJob and nsPrintJob is the only consumer.
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/0bc5888755fd Move and rename nsPrintData::mBrandName to nsPrintJob::mFallbackDocTitle. r=bobowen
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print_v72]
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print_v72] → [print2020_v72]
You need to log in
before you can comment on or make changes to this bug.
Description
•