1593879 - Deleting the default calendar should select a new default

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

If a calendar that was a composite calendar's default is unregistered, it remains the composite calendar's default, which is a bad state.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1593879-select-new-default-calendar-1.diff

This should fix your save prompt in bug 1297426.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9106407 [details] [diff] [review]
1593879-select-new-default-calendar-1.diff

Review of attachment 9106407 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  I can confirm that this does fix the save prompt thing in bug 1297426.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97e2b97e78fa
Select a new default calendar if the current one is removed. r=pmorris

Comment 4

[Jorg K (CEST = GMT+2)]

TB 71 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/2bd2944137e359094aac45f9cd3cdae34fe9e3ac

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9106407 [details] [diff] [review]
1593879-select-new-default-calendar-1.diff

Can you please rebase this for c-esr68. onCalendarUnregistering isn't even in calendar-management.js.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1593879-select-new-default-calendar-esr.diff

Oh yeah, ESR doesn't have any of this code, including the tests broken by this bug. Let's fix the bad state anyway.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68.3 ESR / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/c5f30c678135674c2d78b6464692fb0111dd725b