Closed Bug 1593879 Opened 4 months ago Closed 4 months ago

Deleting the default calendar should select a new default

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

If a calendar that was a composite calendar's default is unregistered, it remains the composite calendar's default, which is a bad state.

This should fix your save prompt in bug 1297426.

Attachment #9106407 - Flags: review?(paul)
Attachment #9106407 - Flags: approval-calendar-esr?(paul)
Attachment #9106407 - Flags: approval-calendar-beta?(paul)
Comment on attachment 9106407 [details] [diff] [review]
1593879-select-new-default-calendar-1.diff

Review of attachment 9106407 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  I can confirm that this does fix the save prompt thing in bug 1297426.
Attachment #9106407 - Flags: review?(paul)
Attachment #9106407 - Flags: review+
Attachment #9106407 - Flags: approval-calendar-esr?(paul)
Attachment #9106407 - Flags: approval-calendar-esr+
Attachment #9106407 - Flags: approval-calendar-beta?(paul)
Attachment #9106407 - Flags: approval-calendar-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/97e2b97e78fa
Select a new default calendar if the current one is removed. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 72
Comment on attachment 9106407 [details] [diff] [review]
1593879-select-new-default-calendar-1.diff

Can you please rebase this for c-esr68. onCalendarUnregistering isn't even in calendar-management.js.
Flags: needinfo?(geoff)
Attachment #9106407 - Flags: approval-calendar-esr+

Oh yeah, ESR doesn't have any of this code, including the tests broken by this bug. Let's fix the bad state anyway.

Flags: needinfo?(geoff)
Attachment #9108858 - Flags: review+
Attachment #9108858 - Flags: approval-calendar-esr+
You need to log in before you can comment on or make changes to this bug.