Closed
Bug 1593920
Opened 6 years ago
Closed 6 years ago
Clean up `HTMLEditor::TabInTable()`
Categories
(Core :: DOM: Editor, task, P2)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
It needs to dispatch beforeinput event but it causes the method messy. We should make it take WidgetKeyboardEvent* and return EditActionResult.
|
Assignee | |
Comment 1•6 years ago
|
||
With making it take WidgetKeyboardEvent*, it won't need to return "handled"
state. However, when we implement beforeinput event, it needs to return
"canceled" state. Therefore, it should return EditActionResult.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/81e8d6935484
Clean up `HTMLEditor::TabInTable()` with taking `WidgetKeyboardEvent*` and returning `EditActionResult` r=m_kato
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•