Closed Bug 1593920 Opened 11 months ago Closed 11 months ago

Clean up `HTMLEditor::TabInTable()`

Categories

(Core :: DOM: Editor, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

It needs to dispatch beforeinput event but it causes the method messy. We should make it take WidgetKeyboardEvent* and return EditActionResult.

With making it take WidgetKeyboardEvent*, it won't need to return "handled"
state. However, when we implement beforeinput event, it needs to return
"canceled" state. Therefore, it should return EditActionResult.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/81e8d6935484
Clean up `HTMLEditor::TabInTable()` with taking `WidgetKeyboardEvent*` and returning `EditActionResult` r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.