1593921 - Use eslint-disable-next-line instead of eslint-disable/enable blocks for complexity issues

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

We have wrapped a few methods in the code base with

/* eslint-disable complexity */
function tooComplexMethod() {
  // ...
}
/* eslint-enable complexity */

When moving code around we can easily break the block, by moving the "enable" lower than intended, or removing it altogether (hence making the disable apply to the whole file).

Since complexity is used on functions, we can alternatively use eslint-disable-next-line. This will be less error prone.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1593921 - Use eslint-disable-next-line to disable complexity checks in DevTools

Using next-line is less error prone for refactorings than wrapping methods with enable/disable blocks.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27157ea1dd60
Use eslint-disable-next-line to disable complexity checks in DevTools r=pbro

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/27157ea1dd60