1593923 - [BinAST] De-duplicate the info about atom

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

In context format, we have 2 places to store atoms, one is BinASTSourceMetadata, and one is BinASTSymbol in Huffman tables.

practically, we just don't need the former after creating the tables, so we can omit that part from metadata and instead store tables.
but might have to think about how XDR works.

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)

practically, we just don't need the former after creating the tables, so we can omit that part from metadata and instead store tables.

this was wrong that table can contain same atom multiple times, and serializing/tracing them isn't efficient.
we should convert the table to point atom in the lists in metadata, instead of directly pointing the atom

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1593923 - Store the index into BinASTSourceMetadata::getAtom in BinASTSymbol instead of JSAtom*. r?Yoric

To store dictionary to BinASTSourceMetadata, JSAtom* needs to be stored
in the single place.

Depends on D52028

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/297273a3b34a
Store the index into BinASTSourceMetadata::getAtom in BinASTSymbol instead of JSAtom*. r=Yoric

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/297273a3b34a