1593944 - Inactive CSS not triggered reliably depending on order of edits

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Kapture 2019-11-05 at 10.55.37.mp4

STR:

1. select any element on any page using the inspector
2. in the rules view, add justify-content: center;
3. add display: flex
4. change the declaration of step 2 to justify-items: center

ER: justify-items is not supported by flexbox and should be marked as inactive
AR: when performing edits in this order, justify-items is not marked as inactive

Comment 1

[Patrick Brosset <:pbro>]

This seems to work for me in DevEdition (71), but fails in nightly (72). I did however get it to work once in nightly still. So this seems a bit intermittent.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1593944 - Emit event with StyleRuleActor as argument when its underlying CSS rule is updated. r=pbro

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1593944 - Test to ensure inactive CSS state does not linger when dependencies change. r=miker,pbro

Depends on D52560

Comment 4

[Razvan Caliman [:rcaliman]]

(In reply to Patrick Brosset <:pbro> from comment #1)

This seems to work for me in DevEdition (71), but fails in nightly (72). I did however get it to work once in nightly still. So this seems a bit intermittent.

It's not intermittent, but it does rely on a very specific set of steps to reproduce:

1. Navigate to:

data:text/html,<style>body { justify-content: center; /*! display: flex */}</style>

2. Open the Inspector and enable the display:flex declaration (justify-content: center becomes active).
3. Rename justify-content to justify-items.

Expected:
The declaration justify-items: center should be marked as inactive (depends on display: grid).

Actual:
The declaration justify-items: center still shows up as active.

---

The root cause is a bug introduced by the fix for bug 1557689 whereby the isUsed flag of declarations is overwritten to a fixed older state of the StyleRuleActor instead of remaining in sync with it as its declarations change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47a58584b813
Emit event with StyleRuleActor as argument when its underlying CSS rule is updated. r=pbro
https://hg.mozilla.org/integration/autoland/rev/b8a3793ecceb
Test to ensure inactive CSS state does not linger when dependencies change. r=miker,pbro

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/47a58584b813
https://hg.mozilla.org/mozilla-central/rev/b8a3793ecceb