1593974 - "See All" button has a white line in the upper part

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect)

Description

[Simona Badau, Desktop QA]

Attachment: SeeAll.mp4

Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0
Build ID: 20191104214406

Affected versions

• Firefox 72.0a1
• Firefox 71.0b7

Affected platforms

• Ubuntu 18.04 x64

Prerequisites
On a new profile modify the following preferences:

• Set "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref to "true"
• Set "browser.contentblocking.cfr-milestone.milestone-achieved" to "1000"
• Set "browser.newtabpage.activity-stream.asrouter.providers.cfr" to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}
• Restart Firefox.

Steps to reproduce:

1. Go to "about:newtab#devtools" page
2. From the "Messages" section, select "cfr" from the drop-down.
3. Scroll down and click on the “show” button from the “MILESTONE_MESSAGE” section in order to force the popup to appear.
4. Observe the "See All" button.

Expected results:
"See All" button is properly displayed.

Actual results:
A white line is displayed at the upper border of the button - please see the attached video for more details. The line is visible when the enabled theme from "about:addons" is the DEFAULT one. When the dark or light themes are enabled, the line is not visible.

Comment 1

[Simona Badau, Desktop QA]

This issue is reproducible also on Windows 10 when a High Contrast theme is enabled (Themes and related settings -> High Contrast settings -> Turn on high contrast -> choose any theme).

Comment 2

[Erica Wright [:ewright]]

The issue is on mac as well, but very subtle. It's a quick fix, so I'll take it.

Comment 3

[Erica Wright [:ewright]]

Attachment: Bug 1593974 - remove top border from celebration button

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e641992b105
remove top border from celebration button r=nhnt11

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8e641992b105

Comment 6

[Erica Wright [:ewright]]

Comment on attachment 9106647 [details]
Bug 1593974 - remove top border from celebration button

Beta/Release Uplift Approval Request

• User impact if declined: Celebration milestone banner does not look correct
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): very small CSS change
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9106647 [details]
Bug 1593974 - remove top border from celebration button

CSS polish fix for an upcoming feature, uplift approved for 71 beta 10, thanks.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/87cc76d88859

Comment 9

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 72.0a1 (20191115095319) and the latest Firefox 71 beta 10 on Ubuntu 18.04, Mac OS X 10.15 and Windows 10 (with enabled high contrast theme).