1593981 - moz-phab --no-arc still uses arc

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

I have a machine where I have no php installed, I thought I could still submit the patch using moz-phab --no-arc, but it seems to still invoke arc:

$ moz-phab --no-arc HEAD~~ HEAD                                                                                                                                                                                                            
Submitting 2 commits for review:
Failed to run /home/emilio/.mozbuild/moz-phab/arcanist/bin/arc.

Comment 1

[Piotr Zalewa [:zalun]]

Please provide the debug log $ DEBUG=1 moz-phab --no-arc HEAD~~ HEAD

Comment 2

[Emilio Cobos Álvarez [:emilio]]

The relevant part of the log is:

DEBUG    2019-11-05 14:10:46,053 Arc stdin: {}
DEBUG    2019-11-05 14:10:46,054 $ /home/emilio/.mozbuild/moz-phab/arcanist/bin/arc --trace call-conduit conduit.ping
DEBUG    2019-11-05 14:10:46,081 /usr/bin/env: ‘php’: No such file or directory

From IRC conversation:

14:13 <emilio> zalun: so, it's checking if `.moz-phab_conduit-configured` exists (it doesn't) and otherwise it tries to call `arc`
14:13 <emilio> zalun: so probably that explains why you don't see it
14:14 <emilio> zalun: (because you've presumably done that in the past)

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Bug 1593981 - Do not ping using Arcanist if `--no-arc` used. r=emilio,glob!