1594056 - Crash in [@ shutdownhang | memset | je_free | mozilla::detail::HashTable<T>::destroyTable | mozilla::scache::StartupCache::~StartupCache]

Status: RESOLVED WORKSFORME

(Toolkit :: Startup and Profile System, defect, P2)

Description

[[:philipp]]

This bug is for crash report bp-52ad50b2-90b7-478b-8dd5-0ee1c0191105.

Top 10 frames of crashing thread:

0 vcruntime140.dll memset f:\dd\vctools\crt\vcruntime\src\string\i386\memset.asm:86
1 mozglue.dll je_free memory/build/malloc_decls.h:54
2 xul.dll static void mozilla::detail::HashTable<mozilla::HashMapEntry<nsTString<char>, mozilla::scache::StartupCacheEntry>, mozilla::HashMap<nsTString<char>, mozilla::scache::StartupCacheEntry, mozilla::scache::nsCStringHasher, mozilla::MallocAllocPolicy>::MapHashPolicy, mozilla::MallocAllocPolicy>::destroyTable mfbt/HashTable.h:1647
3 xul.dll void mozilla::scache::StartupCache::~StartupCache startupcache/StartupCache.cpp:155
4 xul.dll unsigned long PipUIContext::Release xpcom/threads/nsThreadUtils.cpp:39
5 xul.dll mozilla::ShutdownXPCOM xpcom/build/XPCOMInit.cpp:628
6 xul.dll void ScopedXPCOMStartup::~ScopedXPCOMStartup toolkit/xre/nsAppRunner.cpp:1246
7 xul.dll int XREMain::XRE_main toolkit/xre/nsAppRunner.cpp:4761
8 xul.dll XRE_main toolkit/xre/nsAppRunner.cpp:4815
9 xul.dll int mozilla::BootstrapImpl::XRE_main toolkit/xre/Bootstrap.cpp:45

there are a number of shutdown hang signatures regressing in firefox 71 from windows, apparently related to the changes in bug 1550108.

so far there aren't any useful correlations or comments that might provide some better understanding of the circumstances of those crashes yet though.

Comment 1

[Alex Thayer [:alexical] (she/her)]

So, am I understanding these crash reports correctly that somehow the destruction of the table in the StartupCache destructor is taking a long time, causing the watchdog thread to time out and MOZ_CRASH us? I'm not sure if I understand how it says the crashing thread is the main thread but with a reason of MOZ_CRASH("Shutdown too long, probably frozen, causing a crash.")

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mossop, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Pascal Chevrel:pascalc]

We have shipped our last beta for 71, I am setting the status as fix-optional for 71 in case there is a safe uplift possible for these crashes in a potential dot release as a ride-along.

Comment 4

[Dave Townsend [:mossop]]

Doesn't look like this is happening terribly often, but please up the priority if I'm misreading.

Comment 5

[Intermittent Failures Robot]

1 failures in 4528 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux1804-64-tsan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1594056&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 15 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.