1594075 - Ignore unknown directories in repositories and origin directories during temporary storage initialization

Status: RESOLVED WORKSFORME

(Core :: Storage: Quota Manager, defect, P3)

Description

[Tom Tung [:tt, :ttung]]

I believe this might be related to failures on Rep_RestoreDirMeta and Ori_UnexpectedClient

Comment 1

[Jan Varga [:janv]]

Ori_UnexpectedClient yes, but why would this fix Rep_RestoreDirMeta ?

Comment 2

[Jan Varga [:janv]]

Oh I see.

Comment 3

[Tom Tung [:tt, :ttung]]

(In reply to Jan Varga [:janv] from comment #1)

Ori_UnexpectedClient yes, but why would this fix Rep_RestoreDirMeta ?

I suspect this could fix some of the errors in Rep_RestoreDirMeta. Currently, we just assume the directory should be parsable for GetDirectoryMetadata2WithRestoreHelper. If it's not, then we would get Rep_RestoreDirMeta.

I need to look into the code more to understand why we have so many failures on Rep_RestoreDirMeta, but I suspect at least part of them is because of this.

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1594075 - P1 - Ignore the unknown directories in origin directories;

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1594075 - P2 - Ignore the unknown directories in repositories;

Depends on D51873

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f870bccd07ee
P1 - Ignore the unknown directories in origin directories; r=janv

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f870bccd07ee

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24529 (as of Thu, 19 Dec 2019 08:03:17 GMT) ==

Improvements:

3% raptor-tp6-yahoo-mail-firefox-cold loadtime macosx1014-64-shippable opt 1,305.04 -> 1,265.33
3% raptor-tp6-yahoo-mail-firefox-cold macosx1014-64-shippable opt 784.06 -> 761.23

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24529

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Comment 12

[Jens Stutte [:jstutte]]

I assume there is still one patch missing here, though the one attached here is surely bit-rotted.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:edenchuang, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 14

[Jens Stutte [:jstutte]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #13)

:edenchuang, maybe it's time to close this bug?

No.

Comment 15

[Jens Stutte [:jstutte]]

We might want to do some more refactorings in this area, but the defect seems gone.