1594129 - Snippet messages should not be evaluated for trigger actions

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Trigger listeners should use handleMessageRequest (or something similar) to only evaluate related messages.
For example if a openURL trigger is active (not yet seen/blocked) we evaluate all snippet messages for every onLocationChange event.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1594129 - Snippet messages should not be evaluated for trigger actions

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0648ebfc02
Snippet messages should not be evaluated for trigger actions r=k88hudson

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2a0648ebfc02

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9106969 [details]
Bug 1594129 - Snippet messages should not be evaluated for trigger actions

Beta/Release Uplift Approval Request

• User impact if declined: Should improve performance issues surfaced in bug 1599811 along with bug 1594405 which will also be uplifted. (the second uplift is not a dependency, the two are independent and they mitigate the same issue).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch has been in Nightly for a while, and has tests.
  I didn't request uplift sooner because the bugs that signaled the performance issue were for 72.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9106969 [details]
Bug 1594129 - Snippet messages should not be evaluated for trigger actions

This is too late sorry, we are building RC2 and we are no longer in beta to take non-essential uplifts to our release builds.

Comment 6

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9106969 [details]
Bug 1594129 - Snippet messages should not be evaluated for trigger actions

After talking with Andrei, I am taking this uplift in a new RC as it looks safe, has tests and was on nightly for a while.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/a514ead5cb17