1594173 - Add Ad Privacy Info Modal to Top Sites Tile

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Tawanda Kanhema]

Add Ad Privacy Info Modal to Top Sites Tile:

• Impressions
• Clicks
• Dismiss
• CTR to Privacy Page

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5371

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c73a5bc0e225

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (72.0a1 Build ID - 20191114055112) installed, on Windows 10 x64, Arch Linux and Mac 10.15.1. Now, the "Ad Privacy Info Modal" is displayed for the sponsored "Top Sites".

Comment 4

[Gavin Suntop [:gvn] (they/them)]

[Tracking Requested - why for this release]:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Gavin, you are not giving reasons why we should track this bug for 71. Please give an explanation for release managers to understand your context, thanks.

Comment 6

[Scott [:thecount] Downe]

@pascal I can answer that.

This is a bug we need fixed in order to run a revenue based experiment in 71.

It's not going to live users in 71, and we'll see where we go from there depending on the experiment results. Sooner we can test, the sooner we can turn the feature on if it's a revenue plus.

It's a 1 line change too, so I it's low risk.

Comment 7

[Scott [:thecount] Downe]

Attachment: Bug 1594173 - Add Ad Privacy Info Modal to Top Sites Tile

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9109676 [details]
Bug 1594173 - Add Ad Privacy Info Modal to Top Sites Tile

Beta/Release Uplift Approval Request

• User impact if declined: Impact to revenue based experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Update browser.newtabpage.activity-stream.discoverystream.endpoints with https://,http://

2. Update browser.newtabpage.activity-stream.discoverystream.config with {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}
3. Click the three dot context menu on Netflix top site. You should see "Our sponsors & your privacy". Clicking it should show privacy modal.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1 line, verified on nightly.
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9109676 [details]
Bug 1594173 - Add Ad Privacy Info Modal to Top Sites Tile

P1, covered by tests and has steps for manual QA, uplift approved for 71 beta 12, thanks.

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f26871df3887

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the "Ad Privacy Info Modal" is displayed for the sponsored "Top Sites", using the latest Firefox Beta (71.0b12 Build ID - 20191121155457) installed on Windows 10 x64, Arch Linux, and Mac 10.15.1.