1594204 - Add basic inline code path for memory.copy and memory.fill

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

Bug 1591047 improved the performance of our OOL path for memory.copy and memory.fill. This bug will track adding a basic inline code path.

This path may not use SIMD as it looks like it may be easiest to use only GPR's to start with.

Comment 1

[Ryan Hunt [:rhunt]]

Patch with baseline/ion inlines paths for memory.copy (with constant length) and memory.fill (with constant length and value) [1]. It uses up to 64bit registers, but no SIMD.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d9326058070ea27921b26837ad9c2b8516e10e0

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1594204 - Split out 'emitMemCopy' function for dedicated optimizations. r=lth

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1594204 - Generate inline code for memory.copy and memory.fill. r=lth

This commit adds an inline code path for memory.copy/fill for Ion and Baseline
for all platforms. To keep things simple, I reused the plain wasm load/store
codegen with integer types up to 64bits. A future commit can add SIMD support
as needed.

A copy with constant length is reduced to a series of loads (from low-to-high)
onto the value stack (for baseline), or onto a stack of definitions (for ion).
Then a series of stores are emitted (from high-to-low) from the value stack or
temp definition stack.

A fill with constant length and value is reduced to a series of stores (from
high-to-low). The stores use the widest transfer width as possible, and the
value is splatted as appropriate to fill the whole integer.

Depends on D50380

Comment 4

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4aa135034c22a4cac532beb80b0e488e087bc68

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36d41bbf2f46
Split out 'emitMemCopy' function for dedicated optimizations. r=lth
https://hg.mozilla.org/integration/autoland/rev/b0545db75058
Generate inline code for memory.copy and memory.fill. r=lth

Comment 6

[Andreea Pavel [:apavel]]

Backed out for SM bustage at WasmBaselineCompile.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276238068&resultStatus=testfailed%2Cbusted%2Cexception&revision=b0545db75058d5967c77a4836f5d6e4e3115ebf5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276238068&repo=autoland&lineNumber=3218

Backout: https://hg.mozilla.org/integration/autoland/rev/109f738f08cbf047a751bef8fda45f4d053b4278

Comment 7

[Ryan Hunt [:rhunt]]

I need to stop skimping on try runs. Missed no-jit compile error from not adding an entry to MacroAssembler-none.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6295568b6ea4
Split out 'emitMemCopy' function for dedicated optimizations. r=lth
https://hg.mozilla.org/integration/autoland/rev/74cc3a413cb0
Generate inline code for memory.copy and memory.fill. r=lth

Comment 9

[Andreea Pavel [:apavel]]

Backed out for build bustages at WasmBaselineCompile.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276303965&resultStatus=testfailed%2Cbusted%2Cexception&revision=74cc3a413cb0f2da50eb95dff6b6656ce4edabfc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276303965&repo=autoland&lineNumber=3399

Backout: https://hg.mozilla.org/integration/autoland/rev/f6aa348ba29ac0d8310d5ea7a447828dc22f0543

Comment 10

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88db3e7a8fc4fd914e4cf377e9acaf08e29cb0ed

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c65691696b
Split out 'emitMemCopy' function for dedicated optimizations. r=lth
https://hg.mozilla.org/integration/autoland/rev/c06659c20d41
Generate inline code for memory.copy and memory.fill. r=lth

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/26c65691696b
https://hg.mozilla.org/mozilla-central/rev/c06659c20d41