Closed Bug 1594225 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 20100 - Adding toJSON to report and report_body

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20100
Details from upstream follow.

Rodney Ding <rodneyding@google.com> wrote:

Adding toJSON to report and report_body

  • declare BuildJSONValue in report_body as virtual
  • make all sub-class implement override implementation

add toJSON to report_body, making it serializable

  • Includes 4 different reports
  • and parent class LocationReportBody

Bug: 917945
Change-Id: I2ef281aad171ec6a477ae562fab3257847ee4f41
Reviewed-on: https://chromium-review.googlesource.com/1895957
WPT-Export-Revision: 8d187008f4ad865b6c6b81ce1491e6a22c5b7974

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 4 tests and 4 subtests

Firefox

OK : 2
FAIL : 2
TIMEOUT: 2
ERROR : 1

Chrome

OK : 4
FAIL: 4

Safari

OK : 2
FAIL : 2
ERROR : 2
NOTRUN: 2

Firefox-only failures

/reporting/generateTestReport.html: Firefox: ERROR

/feature-policy/reporting/oversized-images-reporting.html: Firefox: TIMEOUT

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f42947c28d1b
[wpt PR 20100] - Adding toJSON to report and report_body, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1740ddea05e6
[wpt PR 20100] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.