1594251 - Assertion failure: !IsAcceptingPromises() immediately after selecting profile by using -P with firefox.exe

Status: RESOLVED DUPLICATE of bug 1591353

(Core :: DOM: Service Workers, defect)

Description

[David Parks [:handyman]]

STR:

1. Run a debug build of Firefox.exe (dist/bin/firefox.exe) with the -P switch to select profile.
2. Choose a profile in the profile window

Expected result:
The profile window process closes and Firefox launches. A Firefox window opens using the chosen profile.

Actual result:
Crashes with this ASSERT:

Assertion failure: !IsAcceptingPromises(), at c:/mozilla-src/mozilla-unified/dom/serviceworkers/ServiceWorkerShutdownBlock
er.cpp:124
#01: mozilla::dom::ServiceWorkerShutdownBlocker::Release (c:\mozilla-src\mozilla-unified\dom\serviceworkers\ServiceWorkerS
hutdownBlocker.cpp:23)
#02: nsCOMPtr_base::~nsCOMPtr_base (c:\mozilla-src\mozilla-unified\obj-debug-64\dist\include\nsCOMPtr.h:331)
#03: nsCOMPtr<nsISupports>::~nsCOMPtr (c:\mozilla-src\mozilla-unified\obj-debug-64\dist\include\nsCOMPtr.h:878)
#04: mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::SegmentImpl<508>::~SegmentImpl (c:\m
ozilla-src\mozilla-unified\obj-debug-64\dist\include\mozilla\SegmentedVector.h:73)
#05: mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::PopLastN (c:\mozilla-src\mozilla-uni
fied\obj-debug-64\dist\include\mozilla\SegmentedVector.h:235)
#06: mozilla::dom::DeferredFinalizerImpl<nsISupports>::DeferredFinalize (c:\mozilla-src\mozilla-unified\obj-debug-64\dist\
include\mozilla\dom\BindingUtils.h:2706)
#07: mozilla::IncrementalFinalizeRunnable::ReleaseNow (c:\mozilla-src\mozilla-unified\xpcom\base\CycleCollectedJSRuntime.c
pp:1283)
#08: mozilla::CycleCollectedJSRuntime::FinalizeDeferredThings (c:\mozilla-src\mozilla-unified\xpcom\base\CycleCollectedJSR
untime.cpp:1357)
#09: mozilla::CycleCollectedJSRuntime::OnGC (c:\mozilla-src\mozilla-unified\xpcom\base\CycleCollectedJSRuntime.cpp:1419)
#10: mozilla::CycleCollectedJSRuntime::GCCallback (c:\mozilla-src\mozilla-unified\xpcom\base\CycleCollectedJSRuntime.cpp:8
33)
#11: js::gc::GCRuntime::callGCCallback (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:1513)
#12: js::gc::GCRuntime::maybeCallGCCallback (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:7164)
#13: js::gc::AutoCallGCCallbacks::~AutoCallGCCallbacks (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:7141)
#14: js::gc::GCRuntime::gcCycle (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:7251)
#15: js::gc::GCRuntime::collect (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:7421)
#16: js::gc::GCRuntime::gc (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:7504)
#17: JS::NonIncrementalGC (c:\mozilla-src\mozilla-unified\js\src\gc\GC.cpp:8332)
#18: mozilla::CycleCollectedJSRuntime::GarbageCollect (c:\mozilla-src\mozilla-unified\xpcom\base\CycleCollectedJSRuntime.c
pp:1158)
#19: nsCycleCollector::FixGrayBits (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3281)
#20: nsCycleCollector::BeginCollection (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3579)
#21: nsCycleCollector::Collect (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3414)
#22: nsCycleCollector::ShutdownCollect (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3357)
#23: nsCycleCollector::Shutdown (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3648)
#24: nsCycleCollector_shutdown (c:\mozilla-src\mozilla-unified\xpcom\base\nsCycleCollector.cpp:3960)
#25: mozilla::ShutdownXPCOM (c:\mozilla-src\mozilla-unified\xpcom\build\XPCOMInit.cpp:714)
#26: NS_ShutdownXPCOM (c:\mozilla-src\mozilla-unified\xpcom\build\XPCOMInit.cpp:568)
#27: ScopedXPCOMStartup::~ScopedXPCOMStartup (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:1233)
#28: ShowProfileManager (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:1870)
#29: SelectProfile (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:1989)
#30: XREMain::XRE_mainStartup (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:3918)
#31: XREMain::XRE_main (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:4725)
#32: XRE_main (c:\mozilla-src\mozilla-unified\toolkit\xre\nsAppRunner.cpp:4821)
#33: mozilla::BootstrapImpl::XRE_main (c:\mozilla-src\mozilla-unified\toolkit\xre\Bootstrap.cpp:45)
#34: do_main (c:\mozilla-src\mozilla-unified\browser\app\nsBrowserApp.cpp:218)
#35: NS_internal_main (c:\mozilla-src\mozilla-unified\browser\app\nsBrowserApp.cpp:300)
#36: wmain (c:\mozilla-src\mozilla-unified\toolkit\xre\nsWindowsWMain.cpp:131)
#37: __scrt_common_main_seh (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
#38: BaseThreadInitThunk[C:\Windows\System32\KERNEL32.DLL +0x17974]
#39: RtlUserThreadStart[C:\Windows\SYSTEM32\ntdll.dll +0x6a271]

Cursory investigation suggests that profile-change-teardown is never sent by this profile window process. Therefore, the ServiceWorker setup is literally in an unexpected state.

I don't think that the -P switch is needed to bring up the profile selector and hit the ASSERT. However, "mach run" skips the profile window and avoids the ASSERT.

Comment 1

[David Parks [:handyman]]

I can comment out the ASSERT for now to skip the crash.