Open Bug 1594255 Opened 5 years ago Updated 2 years ago

[jsdbg2] js::Breakpoint should use js::UncheckedUnwrapWithoutExpose instead of storing a separate Debugger*

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

People

(Reporter: jimb, Unassigned)

References

(Blocks 2 open bugs)

Details

The js::Breakpoint structure includes both a Debugger* pointer and a JSObject* referring to a cross-compartment wrapper of the Debugger JS object for that same Debugger*, because I couldn't figure out how to unwrap the CCW in all the circumstances we needed to. Now that Jon has introduced me to js::UncheckedUnwrapWithoutExpose, I think I could happily use that and remove the redundant field.

Priority: -- → P3
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.