Open Bug 1594280 Opened 2 months ago Updated 2 days ago

Fix usage of nsIDocShellTreeItem in nsDocShell::ValidateOrigin


(Core :: DOM: Navigation, defect, P2)




Fission Milestone M6


(Reporter: djvj, Assigned: tetsuharu)


(Blocks 1 open bug)


(Whiteboard: [rm-docshell-tree-item:simple])


(1 file)

The users of this bug have already changed to ensure that this only gets called when both arguments are in-process.

However, all of the tree-traversal code within this function needs to change to use BrowsingContext instead of nsIDocShellTreeItem to traverse.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:


Fission Milestone: --- → ?
Fission Milestone: ? → M6
Priority: -- → P2
Assignee: nobody → tetsuharu.ohzeki
Attachment #9118189 - Attachment description: Bug 1594280 - Fix usage of nsIDocShellTreeItem in nsDocShell::ValidateOrigin. → Bug 1594280 - Fix uses of nsIDocShellTreeItem in nsIDocShellTreeItem in nsDocShell::ValidateOrigin.
Pushed by
Fix uses of nsIDocShellTreeItem in nsIDocShellTreeItem in nsDocShell::ValidateOrigin. r=kmag

(In reply to Narcis Beleuzu [:NarcisB] from comment #4)

Backed out for mochitest failures on nsDocShell.cpp

Backout link:
Log link:

The previous code checks aTarget->mDocShell guard in caller sides of this function.
After the above backouted patch, we change arguments of this to the style passing BrowsingContext but I forgot aTarget->mDocShell might be null. I'll fix it.

Flags: needinfo?(tetsuharu.ohzeki)
You need to log in before you can comment on or make changes to this bug.