Open Bug 1594280 Opened 2 months ago Updated 2 days ago

Fix usage of nsIDocShellTreeItem in nsDocShell::ValidateOrigin

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

ASSIGNED
Fission Milestone M6

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#1082

The users of this bug have already changed to ensure that this only gets called when both arguments are in-process.

However, all of the tree-traversal code within this function needs to change to use BrowsingContext instead of nsIDocShellTreeItem to traverse.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M6
Priority: -- → P2
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Attachment #9118189 - Attachment description: Bug 1594280 - Fix usage of nsIDocShellTreeItem in nsDocShell::ValidateOrigin. → Bug 1594280 - Fix uses of nsIDocShellTreeItem in nsIDocShellTreeItem in nsDocShell::ValidateOrigin.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ea7d48958f2f
Fix uses of nsIDocShellTreeItem in nsIDocShellTreeItem in nsDocShell::ValidateOrigin. r=kmag

(In reply to Narcis Beleuzu [:NarcisB] from comment #4)

Backed out for mochitest failures on nsDocShell.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/a1dcad5b9e7658d99e720d982a1dfa1e992195ce
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284969624&repo=autoland&lineNumber=10190

The previous code checks aTarget->mDocShell guard in caller sides of this function.
After the above backouted patch, we change arguments of this to the style passing BrowsingContext but I forgot aTarget->mDocShell might be null. I'll fix it.

Flags: needinfo?(tetsuharu.ohzeki)
You need to log in before you can comment on or make changes to this bug.