1594288 - Fix usage of nsIDocShellTreeItem in nsDocShell::FindChildWithName

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#3229

Uses nsIDocShellTreeItem to traverse child tree from document, comparing their names along the way.

This has a surrogate already in BrowsingContext, and all uses should be pointed at that, and this method removed.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1594288 - Remove nsIDocShellTreeItem.findChildWithName. r=annyG!

There are no callers of findChildWithName after it got replaced by
corresponding methods in BrowsingContext.

Comment 3

[Oana Pop-Rus]

Backed out changeset 0e82a2a87b39 (bug 1594288) for causing build bustages in nsDocShell.cpp

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=280690446&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=0e82a2a87b39dca74a9976b151afe6c0ea2ee83f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280690446&repo=autoland&lineNumber=44182

Backout: https://hg.mozilla.org/integration/autoland/rev/c5fd54993583feda01e43bd1f2b1588bd1b44414

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec7033e256bf
Remove nsIDocShellTreeItem.findChildWithName. r=annyG

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ec7033e256bf

Comment 6

[Jorg K (CEST = GMT+2)]

https://searchfox.org/comm-central/search?q=FindChildWithName&case=false&regexp=false&path=mailnews :-(