Closed Bug 1594288 Opened 3 months ago Closed 2 months ago

Fix usage of nsIDocShellTreeItem in nsDocShell::FindChildWithName

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: djvj, Assigned: farre)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#3229

Uses nsIDocShellTreeItem to traverse child tree from document, comparing their names along the way.

This has a surrogate already in BrowsingContext, and all uses should be pointed at that, and this method removed.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M6
Priority: -- → P2
Assignee: nobody → afarre

There are no callers of findChildWithName after it got replaced by
corresponding methods in BrowsingContext.

Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec7033e256bf
Remove nsIDocShellTreeItem.findChildWithName. r=annyG
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
See Also: → 1603649
Flags: needinfo?(afarre)
You need to log in before you can comment on or make changes to this bug.