1594322 - [BinAST] Add unified identity for NormalizedInterfaceAndField and BinASTList

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

To simplify the array/vector handling inside HuffmanDictionary, it's better adding unified identity (index) for NormalizedInterfaceAndField and BinASTList, so that we can handle them with single array/vector.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1594322 - Part 1: Add HuffmanDictionary::TableIdentity to unify NormalizedInterfaceAndField and BinASTList. r?Yoric

For bug 1593922, merged tables/status for field and list length.

Depends on D52029

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1594322 - Part 2: Use HuffmanDictionary::TableIdentity in public methods. r?Yoric

Preparation for Part 4.

Depends on D52030

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1594322 - Part 3: Use HuffmanDictionary::TableIdentity in HuffmanPreludeReader::readTable. r?Yoric

Another preparation for Part 4.

Depends on D52031

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1594322 - Part 4: Add better accessors to HuffmanDictionary. r?Yoric

Hide the internal of status and table creation/access from consumers.

Depends on D52032

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27430d687488
Part 1: Add HuffmanDictionary::TableIdentity to unify NormalizedInterfaceAndField and BinASTList. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/4bd936bc2bb0
Part 2: Use HuffmanDictionary::TableIdentity in public methods. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/f395a7657d62
Part 3: Use HuffmanDictionary::TableIdentity in HuffmanPreludeReader::readTable. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/fd82074eab1d
Part 4: Add better accessors to HuffmanDictionary. r=Yoric

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/27430d687488
https://hg.mozilla.org/mozilla-central/rev/4bd936bc2bb0
https://hg.mozilla.org/mozilla-central/rev/f395a7657d62
https://hg.mozilla.org/mozilla-central/rev/fd82074eab1d