Closed Bug 1594340 Opened Last month Closed Last month

Celebration toast isn't focused using keyboard only in the protection panel

Categories

(Firefox :: Protections UI, defect, P2)

71 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox70 --- unaffected
firefox71 --- verified
firefox72 --- verified

People

(Reporter: hani.yacoub, Assigned: ewright)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Affected versions

  • Firefox Nightly 72.0a1 (2019-11-05)
  • Firefox 71.0b7

Affected platforms

  • macOS 10.14
  • Ubuntu 18.04 x64

Prerequisites

On a new profile modify the following preferences:

  • Set "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref to "true"
  • Set "browser.contentblocking.cfr-milestone.milestone-achieved" to "1000"
  • Set "browser.newtabpage.activity-stream.asrouter.providers.cfr" to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}
  • Restart Firefox.

Steps to reproduce

  1. Go to "about:newtab#devtools" page.
  2. From the "Messages" section, select "cfr" from the drop-down.
  3. Scroll down and click on the “show” button from the “MILESTONE_MESSAGE” section in order to force the popup to appear.
  4. Click on the "Shield" icon.
  5. Using Keyboard only try to access the celebration toast.

Expected result

  • Celebration toast should be focused while using Keyboard only operation.

Actual result

  • Celebration toast isn't focused using keyboard only in the protection panel.
Blocks: 1584313, 1590302
Blocks: 1579974

I tested this, it seems that there is no focus effect, we are just missing some visual feedback. It does get correctly selected and you can hit enter to navigate to the about:protections page.
It should get slightly darker, in the same way that it behaves on hover.

Assignee: nobody → ewright
Status: NEW → ASSIGNED
Attachment #9107275 - Attachment description: Bug 1594340 - Celebration toast has visual feedback when selected with keyboard. → Bug 1594340 - Celebration message is highlighted when selected with keyboard.
Priority: -- → P2
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec91914b87fb
Celebration message is highlighted when selected with keyboard. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Verified as fixed on Firefox Nightly 72.0a1 (2019-11-10) on macOS 10.14 and Ubuntu 18.04 x64.

Comment on attachment 9107275 [details]
Bug 1594340 - Celebration message is highlighted when selected with keyboard.

Beta/Release Uplift Approval Request

  • User impact if declined: Selecting the message in the privacy panel has no visual feedback for the user.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): very small CSS patch
  • String changes made/needed: none
Attachment #9107275 - Flags: approval-mozilla-beta?

Comment on attachment 9107275 [details]
Bug 1594340 - Celebration message is highlighted when selected with keyboard.

One line css selector fix for an upcoming 71 feature, low risk, uplift approved for 71 beta 10, thanks.

Attachment #9107275 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on Firefox 71.0b10 on macOS 10.14 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.