Celebration toast isn't focused using keyboard only in the protection panel
Categories
(Firefox :: Protections UI, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | unaffected |
firefox71 | --- | verified |
firefox72 | --- | verified |
People
(Reporter: hyacoub, Assigned: ewright)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Firefox Nightly 72.0a1 (2019-11-05)
- Firefox 71.0b7
Affected platforms
- macOS 10.14
- Ubuntu 18.04 x64
Prerequisites
On a new profile modify the following preferences:
- Set "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref to "true"
- Set "browser.contentblocking.cfr-milestone.milestone-achieved" to "1000"
- Set "browser.newtabpage.activity-stream.asrouter.providers.cfr" to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}
- Restart Firefox.
Steps to reproduce
- Go to "about:newtab#devtools" page.
- From the "Messages" section, select "cfr" from the drop-down.
- Scroll down and click on the “show” button from the “MILESTONE_MESSAGE” section in order to force the popup to appear.
- Click on the "Shield" icon.
- Using Keyboard only try to access the celebration toast.
Expected result
- Celebration toast should be focused while using Keyboard only operation.
Actual result
- Celebration toast isn't focused using keyboard only in the protection panel.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
I tested this, it seems that there is no focus effect, we are just missing some visual feedback. It does get correctly selected and you can hit enter to navigate to the about:protections page.
It should get slightly darker, in the same way that it behaves on hover.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Reporter | ||
Comment 5•5 years ago
|
||
Verified as fixed on Firefox Nightly 72.0a1 (2019-11-10) on macOS 10.14 and Ubuntu 18.04 x64.
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9107275 [details]
Bug 1594340 - Celebration message is highlighted when selected with keyboard.
Beta/Release Uplift Approval Request
- User impact if declined: Selecting the message in the privacy panel has no visual feedback for the user.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): very small CSS patch
- String changes made/needed: none
Comment 7•5 years ago
|
||
Comment on attachment 9107275 [details]
Bug 1594340 - Celebration message is highlighted when selected with keyboard.
One line css selector fix for an upcoming 71 feature, low risk, uplift approved for 71 beta 10, thanks.
Comment 8•5 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 9•5 years ago
|
||
Verified as fixed on Firefox 71.0b10 on macOS 10.14 and Ubuntu 18.04 x64.
Description
•