Closed
Bug 1594598
Opened 5 years ago
Closed 5 years ago
Some PHC tweaks
Categories
(Core :: Memory Allocator, task)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(4 files)
I will pull out some of the clean-ups from bug 1574390 to get them landed now.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This reduces the indentation level by one for most of the loop body.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Currently the PHC code uses char* and uintptr_t in various address
computations. This patch changes it to use uint8_t* instead, which is clearer
than char* and avoids the need for various casts.
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99e7c9afdf92 Fix some broken PHC_LOGGING code. r=glandium https://hg.mozilla.org/integration/autoland/rev/f17d8e2af670 Tweak the control flow in MaybePageAlloc()'s loop. r=glandium https://hg.mozilla.org/integration/autoland/rev/ba5dde550477 Improve some PHC comments. r=glandium https://hg.mozilla.org/integration/autoland/rev/ec3308aa7246 Use uint8_t* to avoid a bunch of casts. r=glandium
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/99e7c9afdf92
https://hg.mozilla.org/mozilla-central/rev/f17d8e2af670
https://hg.mozilla.org/mozilla-central/rev/ba5dde550477
https://hg.mozilla.org/mozilla-central/rev/ec3308aa7246
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Updated•5 years ago
|
Assignee: nobody → n.nethercote
You need to log in
before you can comment on or make changes to this bug.
Description
•