1594598 - Some PHC tweaks

Status: RESOLVED FIXED

(Core :: Memory Allocator, task)

Description

[Nicholas Nethercote [inactive]]

I will pull out some of the clean-ups from bug 1574390 to get them landed now.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1594598 - Fix some broken PHC_LOGGING code. r=glandium

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1594598 - Tweak the control flow in MaybePageAlloc()'s loop. r=glandium

This reduces the indentation level by one for most of the loop body.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1594598 - Improve some PHC comments. r=glandium

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1594598 - Use uint8_t* to avoid a bunch of casts. r=glandium

Currently the PHC code uses char* and uintptr_t in various address
computations. This patch changes it to use uint8_t* instead, which is clearer
than char* and avoids the need for various casts.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e7c9afdf92
Fix some broken PHC_LOGGING code. r=glandium
https://hg.mozilla.org/integration/autoland/rev/f17d8e2af670
Tweak the control flow in MaybePageAlloc()'s loop. r=glandium
https://hg.mozilla.org/integration/autoland/rev/ba5dde550477
Improve some PHC comments. r=glandium
https://hg.mozilla.org/integration/autoland/rev/ec3308aa7246
Use uint8_t* to avoid a bunch of casts. r=glandium

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/99e7c9afdf92
https://hg.mozilla.org/mozilla-central/rev/f17d8e2af670
https://hg.mozilla.org/mozilla-central/rev/ba5dde550477
https://hg.mozilla.org/mozilla-central/rev/ec3308aa7246