Closed Bug 1594639 Opened 3 years ago Closed 2 months ago

cmd+option r should respect binary path

Categories

(DevTools :: General, task, P3)

Product:
DevTools
Component:
General
Type:
task

Tracking

(firefox101 fixed)

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: jlast, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1594639 - [devtools] Pass option dictionary to BrowserToolboxLauncher.init.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1594639 - [devtools] Ensure reusing browser toolbox custom binary path on reload.
48 bytes, text/x-phabricator-request
Details | Review

What were you doing?

  • ./mach run --jsdebugger $NIGHTLY successfully sets the path for the browser toolbox
  • cmd+option+r should use that path when re-running firefox
Priority: -- → P3

This will be slightly easier to understand which argument we pass.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

I tried various approaches around the session restore, but this isn't reliable.
Using an environment variable is much easier and also help making the path global
for the whole instance in case we close and reopen it.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5ca537830f0
[devtools] Pass option dictionary to BrowserToolboxLauncher.init. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2557d94365b7
[devtools] Ensure reusing browser toolbox custom binary path on reload. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/d5ca537830f0
https://hg.mozilla.org/mozilla-central/rev/2557d94365b7

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.