1594685 - Perma Beta REFTEST PROCESS-CRASH | /reftest/tests/layout/style/crashtests/1593766.html | application crashed [@ mozilla::dom::Worklet::Worklet(nsPIDOMWindowInner*, RefPtr<mozilla::WorkletImpl>, nsISupports*)] when Gecko 72 merges to Beta on 2019-12-02

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Alexandru Michis [:malexandru]]

Central as Beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79a10eb84e707f42814b4ac803be9bdc535a14f2&searchStr=crashtest&group_state=expanded

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275033927&repo=try&lineNumber=17781

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275034014&repo=try&lineNumber=81077

[task 2019-11-07T10:51:31.406Z] 10:51:31 INFO - REFTEST INFO | Copy/paste: /builds/worker/workspace/build/linux64-minidump_stackwalk /tmp/tmpBfY9h2.mozrunner/minidumps/680c1fb1-08a9-21af-bc94-c243ed29f83d.dmp /builds/worker/workspace/build/symbols
[task 2019-11-07T10:51:36.511Z] 10:51:36 INFO - REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/680c1fb1-08a9-21af-bc94-c243ed29f83d.dmp
[task 2019-11-07T10:51:36.513Z] 10:51:36 INFO - REFTEST INFO | Saved app info as /builds/worker/workspace/build/blobber_upload_dir/680c1fb1-08a9-21af-bc94-c243ed29f83d.extra
[task 2019-11-07T10:51:36.620Z] 10:51:36 INFO - REFTEST PROCESS-CRASH | file:///builds/worker/workspace/build/tests/reftest/tests/layout/style/crashtests/1593766.html | application crashed [@ mozilla::dom::Worklet::Worklet(nsPIDOMWindowInner*, RefPtr<mozilla::WorkletImpl>, nsISupports*)]
[task 2019-11-07T10:51:36.621Z] 10:51:36 INFO - Crash dump filename: /tmp/tmpBfY9h2.mozrunner/minidumps/680c1fb1-08a9-21af-bc94-c243ed29f83d.dmp
[task 2019-11-07T10:51:36.622Z] 10:51:36 INFO - Operating system: Linux
[task 2019-11-07T10:51:36.623Z] 10:51:36 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2019-11-07T10:51:36.624Z] 10:51:36 INFO - CPU: amd64
[task 2019-11-07T10:51:36.625Z] 10:51:36 INFO - family 6 model 85 stepping 4
[task 2019-11-07T10:51:36.626Z] 10:51:36 INFO - 1 CPU
[task 2019-11-07T10:51:36.627Z] 10:51:36 INFO -
[task 2019-11-07T10:51:36.628Z] 10:51:36 INFO - GPU: UNKNOWN
[task 2019-11-07T10:51:36.629Z] 10:51:36 INFO -
[task 2019-11-07T10:51:36.630Z] 10:51:36 INFO - Crash reason: SIGSEGV /SEGV_MAPERR
[task 2019-11-07T10:51:36.631Z] 10:51:36 INFO - Crash address: 0x0
[task 2019-11-07T10:51:36.632Z] 10:51:36 INFO - Process uptime: not available
[task 2019-11-07T10:51:36.633Z] 10:51:36 INFO -
[task 2019-11-07T10:51:36.634Z] 10:51:36 INFO - Thread 0 (crashed)
[task 2019-11-07T10:51:36.635Z] 10:51:36 INFO - 0 libxul.so!mozilla::dom::Worklet::Worklet(nsPIDOMWindowInner*, RefPtr<mozilla::WorkletImpl>, nsISupports*) [Worklet.cpp:d08af309749be4d56eb8a70e88986b91a774527b : 440 + 0x29]
[task 2019-11-07T10:51:36.636Z] 10:51:36 INFO - rax = 0x00007fb50b643471 rdx = 0x0000000000000000
[task 2019-11-07T10:51:36.637Z] 10:51:36 INFO - rcx = 0x000055766cf78980 rbx = 0x00007fb486b56ac0
[task 2019-11-07T10:51:36.637Z] 10:51:36 INFO - rsi = 0x00007fb5177f8770 rdi = 0x00007fb5177f7540
[task 2019-11-07T10:51:36.638Z] 10:51:36 INFO - rbp = 0x00007ffd1e06efd0 rsp = 0x00007ffd1e06efa0
[task 2019-11-07T10:51:36.638Z] 10:51:36 INFO - r8 = 0x00007fb5177f8770 r9 = 0x00007fb518854740
[task 2019-11-07T10:51:36.639Z] 10:51:36 INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000000
[task 2019-11-07T10:51:36.639Z] 10:51:36 INFO - r12 = 0x0000000000000000 r13 = 0x00007fb4d469fd90
[task 2019-11-07T10:51:36.640Z] 10:51:36 INFO - r14 = 0x00007fb487211820 r15 = 0x00007ffd1e06efe0
[task 2019-11-07T10:51:36.640Z] 10:51:36 INFO - rip = 0x00007fb5074a7d6a
[task 2019-11-07T10:51:36.641Z] 10:51:36 INFO - Found by: given as instruction pointer in context
[task 2019-11-07T10:51:36.641Z] 10:51:36 INFO - 1 libxul.so!already_AddRefed<mozilla::dom::Worklet> mozilla::MakeAndAddRef<mozilla::dom::Worklet, nsPIDOMWindowInner*&, RefPtr<mozilla::PaintWorkletImpl> >(nsPIDOMWindowInner*&, RefPtr<mozilla::PaintWorkletImpl>&&) [RefPtr.h:d08af309749be4d56eb8a70e88986b91a774527b : 571 + 0x39]
[task 2019-11-07T10:51:36.642Z] 10:51:36 INFO - rbx = 0x00007ffd1e06f038 rbp = 0x00007ffd1e06f020
[task 2019-11-07T10:51:36.642Z] 10:51:36 INFO - rsp = 0x00007ffd1e06efe0 r12 = 0x00007fb487211820
[task 2019-11-07T10:51:36.643Z] 10:51:36 INFO - r13 = 0x00007fb4d469fd90 r14 = 0x00007ffd1e06f080
[task 2019-11-07T10:51:36.643Z] 10:51:36 INFO - r15 = 0x00007fb486b56ac0 rip = 0x00007fb5077bbd03
[task 2019-11-07T10:51:36.644Z] 10:51:36 INFO - Found by: call frame info
[task 2019-11-07T10:51:36.644Z] 10:51:36 INFO - 2 libxul.so!mozilla::PaintWorkletImpl::CreateWorklet(nsPIDOMWindowInner*, nsIPrincipal*) [PaintWorkletImpl.cpp:d08af309749be4d56eb8a70e88986b91a774527b : 20 + 0xb]
[task 2019-11-07T10:51:36.645Z] 10:51:36 INFO - rbx = 0x00007ffd1e06f038 rbp = 0x00007ffd1e06f070

Looks to be triggered by: https://hg.mozilla.org/mozilla-central/file/7e056a6f4792bac214531647fdfaac1443b2c4e2/dom/worklet/Worklet.cpp#l440

Karl, can you take a look?

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: skip 1593766.html on release_beta due to intentional crash on attempt to use nightly-only feature

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 3

[Andreea Pavel [:apavel]]

Karl, importing the patch fixes the crash, can it land on integration?

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=938cfeed4b3bbe8f2f074887acee03756459ba34&searchStr=crashtest

Comment 4

[Karl Tomlinson (:karlt)]

Thanks for testing. I've queued for landing, but "Tree gecko" has been closed for while.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d1326935041
skip 1593766.html on release_beta due to intentional crash on attempt to use nightly-only feature r=baku

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3d1326935041

Comment 7

[Alexandru Michis [:malexandru]]

Verified fixed in today's central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=d0ba5ea886d9a30f46817ff79edc05fa5f85d411&searchStr=%28c