1594743 - When performing keyboard and label checks at the same time, accessible name is reported as null when used inside a label check.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

This is a really weird bug that happens when we have keyboard and text label and names checks happen at the same time. Whenever we query accessible's name, it is reported as null, even though it should something non-empty. This seems to happen somehow because of the call to InspectorUtils.addPseudoClassLock... If I disable that line where we are checking if an element has pseudo focus styling, the name is reported correctly...

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Doesn't seem like there are any accessible events fired when applying the lock..

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Just FYI these are the functions that area called when the lock is applied, perhaps something triggers some sort of change in platform a11y:

InspectorUtils::AddPseudoClassLock
-> Element::LockStyleStates
---> Element::NotifyStyleStateChange
-----> PresShell::ContentStateChanged
-------> RestyleManager::ContentStateChanged

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1594743 - ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e727898953ed
ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e727898953ed

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9107544 [details]
Bug 1594743 - ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe

Beta/Release Uplift Approval Request

• User impact if declined: Keyboard audit currently interferes with other audits and needs to be done separately. Users of the a11y panel will see false positives that happen because of that.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch simply ensures that the a11y audit for keyboard happens before all other ones instead of at the same time.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9107544 [details]
Bug 1594743 - ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe

Uplift approved for 71 beta 11, thanks.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/73a6d9d8995f